Skip to content

add subclass based method for inference #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: drisspg/stack/49
Choose a base branch
from

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Apr 25, 2025

stack-info: PR: #2132, branch: drisspg/stack/50
Copy link

pytorch-bot bot commented Apr 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2132

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 34fa252 with merge base 868afa6 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2025
@@ -53,4 +53,5 @@
"swizzle",
"testing",
"ops",
"quantization",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is swizzle top level?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a really good question

return f"in_features={self.weight.shape[1]}, out_features={self.weight.shape[0]}, weight={repr(self.weight)}"


def _input_activation_quant_func_mxfp(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add to safe global for serialization?

torch.serialization.add_safe_globals(

@drisspg
Copy link
Contributor Author

drisspg commented Apr 26, 2025

Sorry, this should be a draft still, I am just dumping all my commits for now

@jerryzh168

@drisspg drisspg changed the base branch from drisspg/stack/49 to main April 26, 2025 01:05
@drisspg drisspg changed the base branch from main to drisspg/stack/49 April 26, 2025 01:05
@drisspg drisspg mentioned this pull request Apr 26, 2025
@drisspg drisspg changed the base branch from drisspg/stack/49 to main April 26, 2025 01:18
@drisspg drisspg changed the base branch from main to drisspg/stack/49 April 26, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants