Fix NVFP4 to_copy #2812
Merged
Fix NVFP4 to_copy #2812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary:** Fixes #2811 **Test Plan:** ``` pytest test/prototype/mx_formats/test_nvfp4_tensor.py -k to_copy ```
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2812
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled JobAs of commit fb5e41c with merge base 083361b ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
andrewor14
added
the
topic: improvement
drisspg
approved these changes
Aug 19, 2025
|
Great catch! |
andrewor14
added
topic: bug fix
jerryzh168
reviewed
Aug 20, 2025
| @pytest.mark.skipif( | ||
| not TORCH_VERSION_AT_LEAST_2_8, reason="NVFP4 requires PyTorch 2.8+" | ||
| ) | ||
| def test_nvfp4_to_copy(): |
There was a problem hiding this comment.
should we verify the effect for to_copy as well?
andrewor14
force-pushed
the
fix-nvfp4-to-copy
branch
from
1ddb363 to
6b794bb
Compare
andrewor14
force-pushed
the
fix-nvfp4-to-copy
branch
from
6b794bb to
fb5e41c
Compare
andrewor14
added a commit
that referenced
this pull request
Aug 22, 2025
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
* Fix NVFP4 to_copy **Summary:** Fixes #2811 **Test Plan:** ``` pytest test/prototype/mx_formats/test_nvfp4_tensor.py -k to_copy ``` * Update test_nvfp4_tensor.py
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fixes #2811
Test Plan: