Skip to content

Conversation

andrewor14
Copy link
Contributor

Summary: We recently deprecated these variables but we're still using them in torchao. We should replace all of them with torch_version_at_least so users don't see these deprecation warnings when they're just importing torchao.

Test Plan: Manual import

Copy link

pytorch-bot bot commented Aug 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2852

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit fe9fde5 with merge base a9ffa50 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 22, 2025
@andrewor14 andrewor14 added the topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) label Aug 22, 2025
**Summary:** We recently deprecated these variables but we're
still using them in torchao. We should replace all of them with
`torch_version_at_least` so users don't see these deprecation
warnings when they're just importing torchao.

**Test Plan:** Manual import
@andrewor14 andrewor14 force-pushed the fix_torch_version_warning branch from 2d0fbd6 to fe9fde5 Compare August 22, 2025 18:46
@andrewor14 andrewor14 merged commit 9978bca into main Aug 22, 2025
15 of 18 checks passed
andrewor14 added a commit that referenced this pull request Aug 22, 2025
andrewor14 added a commit that referenced this pull request Aug 22, 2025
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
**Summary:** We recently deprecated these variables but we're
still using them in torchao. We should replace all of them with
`torch_version_at_least` so users don't see these deprecation
warnings when they're just importing torchao.

**Test Plan:** Manual import
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants