Make FqnToConfig handle module swap configs #3492
Open
+69
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3492
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8bfc239 with merge base ff6d9e2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
**Summary:** `FqnToConfig` does not handle module swap configs like `QATConfig` today because it does not reassign the replaced modules, but instead assumes there is no need to do so because the underlying tensors are swapped. This breaks when the user tries to use `FqnToConfig` with `QATConfig`, which does not rely on tensor subclasses. This commit fixes this by making the replacement logic in `FqnToConfig` more general. Fixes #3490. **Test Plan:** ``` python test/quantization/test_quant_api.py -k test_fqn_config_quantized_nested_module_module_swap ```
andrewor14
force-pushed
the
fqn-to-config-qat
branch
from
50b55f5 to
8bfc239
Compare
vkuzo
reviewed
Dec 16, 2025
| module.to(device=device) | ||
| return | ||
| if isinstance(config, AOBaseConfig): | ||
| _fqn_to_config_replace(config, model, device=device) |
Contributor
There was a problem hiding this comment.
this is hard to follow, would it be cleaner to use iteration instead of recursion here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
FqnToConfigdoes not handle module swap configs likeQATConfigtoday because it does not reassign the replaced modules, but instead assumes there is no need to do so because the underlying tensors are swapped. This breaks when the user tries to useFqnToConfigwithQATConfig, which does not rely on tensor subclasses. This commit fixes this by making the replacement logic inFqnToConfigmore general.Fixes #3490.
Test Plan: