-
Notifications
You must be signed in to change notification settings - Fork 700
Port autograd parts of lfilter to python #3954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3954
Note: Links to docs will display an error until the docs builds have been completed. ❌ 8 New FailuresAs of commit 3b3e0dd with merge base bf4e412 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
07c5564
to
37f5685
Compare
e7be26a
to
4a1753d
Compare
@@ -100,194 +100,19 @@ void lfilter_core_generic_loop( | |||
} | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've got lfilter_core_generic_loop
left-over above in this file. Is it still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. That path was used before if you had tensors on a cuda device but you hadn't compiled torchaudio with support for CUDA. We should probably still keep it around. I think we can register it with the dispatcher as a CompositeExplicitAutograd
path, which, as I understand it, will work as a catch-all if other dispatcher keys don't kick in.
a530095
to
3b3e0dd
Compare
PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.