Remove dropping_support decorators.
#4056
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4056
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This PR requires a rebase against the |
samanklesaria
changed the base branch from
no_wrap_ctc_decoder
to
pseudo_main
samanklesaria
force-pushed
the
remove_dropping_support
branch
from
c1e3840 to
299376b
Compare
samanklesaria
changed the base branch from
pseudo_main
to
no_wrap_ctc_decoder
|
Sucessfully rebased against main. We just need to wait for #4055 to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that all functions we deprecated in 2.8 have been removed, there is no need for the
dropping_supportfamily of decorators. This PR removes them. It also un-deprecates the stable ABI ported functions. Note that this PR dependsno_wrap_ctc_decoder.