Skip to content

Conversation

samanklesaria
Copy link
Collaborator

This PR is in response to #4083. The old version of conda used by pytorch-infra can't resolve the environment well enough to install ffmpeg, so we have to resort to the manual building step given by the ffmpeg github workflow. But @pearu thinks this problem could go away if we just used a more modern conda. This PR is a work in progress- it installs a fresh miniconda and attempts to activate it before building the rest of the docs.

Copy link

pytorch-bot bot commented Sep 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4090

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 6b7e190 with merge base 2e30055 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Sep 4, 2025
Copy link
Collaborator

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace

        echo "::group::Build FFmpeg"
        .github/scripts/ffmpeg/build_gpu.sh

with

conda install -q -y ffmpeg

It the doc build time will stay around 15 minutes (as it is now), building ffmpeg within torchaudio can be eliminated.

@samanklesaria
Copy link
Collaborator Author

Not working yet- it seems the system pip is still being used, not one associated with miniconda. In general, I find working with all the different kinds of conda spinoffs quite confusing; if I continue to encounter problems with the miniconda approach, I might just switch doing the build with pixi instead.

@pearu pearu added this to the 2.9 milestone Sep 5, 2025
@pearu pearu changed the title Try installing miniconda rather than using old installation Try installing miniforge rather than using old conda installation with slow solver Sep 5, 2025
@pearu pearu changed the title Try installing miniforge rather than using old conda installation with slow solver Install conda from miniforge rather than using old conda installation with a slow solver Sep 5, 2025
Copy link
Collaborator

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @samanklesaria!

Removing ffmpeg build can be finished in #4083 .

@pearu
Copy link
Collaborator

pearu commented Sep 5, 2025

If waiting for green CI is blocking on #4083, I suggest merge this PR as the changes in this PR affects only docs build and it was successful (modulo a known test-infra issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants