Skip to content

Move gflags to third-party #11448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2025
Merged

Move gflags to third-party #11448

merged 3 commits into from
Jun 9, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented Jun 6, 2025 •
edited by pytorch-bot bot
Loading

Summary

gflags is just used by the runner, so we could technically add it only if EXECUTORCH_BUILD_EXECUTOR_RUNNER is not. However, all the examples assume gflags is always built and directly uses the library. So for simplicity, let's just always include it for now (the default right now anyways).

Test plan

CI

cc @larryliu0820

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11448

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 7fd7ba7 with merge base a7a9130 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025
@jathu jathu added ciflow/trunk ciflow/binaries release notes: none Do not include this in the release notes module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 6, 2025
@jathu jathu force-pushed the jathu/move-gflags branch from 4f324d6 to d53e93c Compare June 6, 2025 18:26
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025
@jathu jathu marked this pull request as ready for review June 6, 2025 18:30
@jathu jathu force-pushed the jathu/move-gflags branch from d53e93c to 5f58949 Compare June 6, 2025 18:32
@jathu jathu requested review from shoumikhin and cccclai as code owners June 6, 2025 18:32
@jathu jathu merged commit 37c104b into main Jun 9, 2025
213 checks passed
@jathu jathu deleted the jathu/move-gflags branch June 9, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin approved these changes

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

Assignees
No one assigned
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jathu @mergennachin @larryliu0820 @facebook-github-bot