-
Notifications
You must be signed in to change notification settings - Fork 585
Enforce required cmake flags as explicit requirements #11457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jathu
wants to merge
1
commit into
main
Choose a base branch
from
jathu/cmake-explicit-flag-requires
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+81
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11457
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit d189a21 with merge base 2bb567f ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
e3fba22
to
60fa340
Compare
60fa340
to
469e165
Compare
28bcb5d
to
e8aec99
Compare
ac1180e
to
e23f1cc
Compare
e23f1cc
to
9e19d27
Compare
larryliu0820
reviewed
Jun 6, 2025
larryliu0820
reviewed
Jun 6, 2025
larryliu0820
reviewed
Jun 6, 2025
larryliu0820
approved these changes
Jun 6, 2025
9e19d27
to
02e8f57
Compare
jathu
added a commit
that referenced
this pull request
Jun 6, 2025
### Summary Some flags require other flags to also be turned on. So this function helps use enforce it. ### Test plan Used in: #11457 ``` $ python -m unittest tools.cmake.common.preset_test.TestPreset ``` cc @larryliu0820
ce72c8c
to
86602c7
Compare
86602c7
to
d189a21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/binaries
ciflow/trunk
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
module: build/install
Issues related to the cmake and buck2 builds, and to installing ExecuTorch
release notes: none
Do not include this in the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The build file currently turns on a bunch of implicitly dependent flags, perhaps unnecessarily. Let's make these dependencies explicit now.
For example, previously if
EXECUTORCH_BUILD_EXTENSION_TRAINING
was turned on, it would then turn on its own set of dependencies. This is good from a developer experience point of view because users would need to just turn on one flag. However, from a build point of view, it makes it harder to maintain and understand what flags are conflicting with one another. Now, if you want to build the training extension, you will have to explicitly turn on the required flags. However, with our build presets — most developers should not have to do to this!I have created a follow up ticket to actually comb through the existing flags and trim the fat if necessary: #11458
Test plan
CI
cc @larryliu0820