Skip to content

[5/N] Add update in method #11463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: gh/cccclai/25/base
Choose a base branch
from
Open

[5/N] Add update in method #11463

wants to merge 4 commits into from

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Jun 6, 2025 •
edited
Loading

@cccclai
[5/N] Add update in method
1596ba3 
Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood.

Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/)

[ghstack-poisoned]
This was referenced Jun 6, 2025
Open
Open
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11463

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 2 Unrelated Failures

As of commit a26ada5 with merge base f7cc72f (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jun 6, 2025
Open
Open
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025
cccclai added a commit that referenced this pull request Jun 6, 2025
@cccclai
[5/N] Add update in method
8808b3e 
Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood.

Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/)

ghstack-source-id: 288753956
Pull Request resolved: #11463
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76149467

@cccclai
Update on "[5/N] Add update in method"
f1f105c 
Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood.

Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/)

[ghstack-poisoned]
This was referenced Jun 10, 2025
Open
Open
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76149467

@cccclai
Update on "[5/N] Add update in method"
142fdbd 
Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood.

Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76149467

kimishpatel
kimishpatel reviewed Jun 13, 2025
View reviewed changes
runtime/executor/test/method_update_test.cpp
void load_program() {
// Since these tests cause ET_LOG to be called, the PAL must be initialized
// first.
executorch::runtime::runtime_init();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already happens in Setup too

kimishpatel
kimishpatel reviewed Jun 13, 2025
View reviewed changes
runtime/executor/method.cpp
const char* backend_name = entry.backend_name;
auto backend_options = entry.options;

auto backend_class = get_backend_class(backend_name);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does backend class give you a singleton instance of backend interface? If so why do we need to pipe it up via Method class. Just make something like executorch::backend::set_options(BackendOptions&) (I dont think BackendOptions constructor exist? but probably would be good to add)

Copy link
Contributor Author

@cccclai cccclai Jun 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it doesn't. I did only for the test backend I added, just so I can check if the config inside the backend is indeed changed in the test.

@cccclai
Update on "[5/N] Add update in method"
a26ada5 
Expose the update API in method. This API will take BackendOptionMap as input and call backend_interface->update under the hood.

Differential Revision: [D76149467](https://our.internmc.facebook.com/intern/diff/D76149467/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76149467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimishpatel kimishpatel kimishpatel left review comments

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cccclai @facebook-github-bot @kimishpatel