Skip to content

Export a lora model #12875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2025
Merged

Export a lora model #12875

merged 3 commits into from
Jul 28, 2025

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11045 by @lucylq
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/83/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/83/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/82/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/83/orig
@diff-train-skip-merge

lucylq added 2 commits July 24, 2025 14:27
@lucylq
Add LoRA linear definition
172b3f5 
Pull Request resolved: #11044

^
Add lora linear definition. Pull out linears from attention, and allow custom linear (eg. lora linear) to be passed in.

If none, construct linear (current behaviour).
ghstack-source-id: 298411928
@exported-using-ghexport

Differential Revision: [D73953776](https://our.internmc.facebook.com/intern/diff/D73953776/)
@lucylq
Export a lora model
c77a4bd 
Pull Request resolved: #11045

^

Program+data combined currently, using the lora linear definition.
ghstack-source-id: 298641176

Differential Revision: [D75153377](https://our.internmc.facebook.com/intern/diff/D75153377/)
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12875

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 0806b4f with merge base 6d4b68a (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 26, 2025
Base automatically changed from gh/lucylq/82/orig to main July 26, 2025 02:11
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign kirklandsign merged commit cfee537 into main Jul 28, 2025
97 of 99 checks passed
@kirklandsign kirklandsign deleted the gh/lucylq/83/orig branch July 28, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucylq lucylq lucylq approved these changes

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

@mcr229 mcr229 Awaiting requested review from mcr229 mcr229 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pytorchbot @lucylq @facebook-github-bot @kirklandsign