Use quantizable LSTM in test when flow has quantize=True #14893
Merged
+63
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes more sense to use the quantizable version of the LSTM. For example, right now the xnnpack int8 tests pass, even though all tensors are float, since the quantizer is not triggered. Signed-off-by: Erik Lundell <[email protected]> Change-Id: I0dc3fff7d1c6c6e6480ca33ec46efa88327c5285
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14893
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 PendingAs of commit b31b5cc with merge base 0b748bf ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Erik-Lundell
added
partner: arm
Erik-Lundell
requested review from
GregoryComer
and removed request for
cccclai
Erik-Lundell
changed the title
zingo
added
backend tester
Erik-Lundell
added
the
release notes: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes more sense to use the quantizable version of the LSTM. For example, right now the xnnpack int8 tests pass, even though all tensors are float, since the quantizer is not triggered.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai