Skip to content

[Executorch][llama] Split main in lib + binary #15919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: gh/kimishpatel/215/base
Choose a base branch
from
Open

[Executorch][llama] Split main in lib + binary #15919

wants to merge 2 commits into from
+12 −2

Conversation

@kimishpatel
Copy link
Contributor

@kimishpatel kimishpatel commented Nov 20, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Main reason to do so is to allow internal benchmarking binary to link against main_lib

Differential Revision: D87547090

@kimishpatel
[Executorch][llama] Split main in lib + binary
947e62e 
Main reason to do so is to allow internal benchmarking binary to link against main_lib

Differential Revision: [D87547090](https://our.internmc.facebook.com/intern/diff/D87547090/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15919

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kimishpatel added a commit that referenced this pull request Nov 20, 2025
@kimishpatel
[Executorch][llama] Split main in lib + binary
76d83cc 
Main reason to do so is to allow internal benchmarking binary to link against main_lib

Differential Revision: [D87547090](https://our.internmc.facebook.com/intern/diff/D87547090/)

ghstack-source-id: 324690959
Pull Request resolved: #15919
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2025
@github-actions
Copy link

github-actions bot commented Nov 20, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

lucylq
lucylq reviewed Nov 20, 2025
View reviewed changes
examples/models/llama/targets.bzl Outdated
runtime.cxx_binary(
name = "main" + aten_suffix,
runtime.cxx_library(
name = "main" + aten_suffix + "_lib",
Copy link
Contributor

@lucylq lucylq Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "main_lib" + aten_suffix

Copy link
Contributor Author

@kimishpatel kimishpatel Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

lucylq
lucylq reviewed Nov 20, 2025
View reviewed changes
examples/models/llama/targets.bzl Outdated
name = "main" + aten_suffix,
srcs = [],
deps = [
":main" + aten_suffix + "_lib",
Copy link
Contributor

@lucylq lucylq Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, ":main_lib" + aten_suffix,

@kimishpatel
Update on "[Executorch][llama] Split main in lib + binary"
c21b003 
Main reason to do so is to allow internal benchmarking binary to link against main_lib

Differential Revision: [D87547090](https://our.internmc.facebook.com/intern/diff/D87547090/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Nov 25, 2025
@kimishpatel
[Executorch][llama] Split main in lib + binary
e4718c5 
Pull Request resolved: #15919

Main reason to do so is to allow internal benchmarking binary to link against main_lib

Differential Revision: [D87547090](https://our.internmc.facebook.com/intern/diff/D87547090/)
ghstack-source-id: 325659293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucylq lucylq lucylq approved these changes

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kimishpatel @lucylq