Skip to content

Forward fix eval_llama_qnn #15952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Forward fix eval_llama_qnn #15952

wants to merge 1 commit into from

Conversation

@cccclai
Copy link
Contributor

@cccclai cccclai commented Nov 22, 2025

#15807 break the eval flow. Forward fix

@cccclai
Forward fix eval_llama_qnn
323c74a 
#15807 break the eval flow. Forward fix
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15952

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2025
@cccclai cccclai added ciflow/trunk and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Nov 22, 2025
@github-actions
Copy link

github-actions bot commented Nov 22, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2025
DannyYuyang-quic
DannyYuyang-quic reviewed Nov 24, 2025
View reviewed changes
examples/qualcomm/oss_scripts/llama/eval_llama_qnn.py
quant_dtype = getattr(QuantDtype, f"use_{args.ptq}")
decoder_model_config = SUPPORTED_LLM_MODELS[args.decoder_model]
custom_annotations = decoder_model_config.custom_annotation
custom_annotations = decoder_model_config.quant_recipe.custom_quant_annotations
Copy link
Contributor

@DannyYuyang-quic DannyYuyang-quic Nov 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late catch. I just saw this PR.
And it actually needs to be called like this:

custom_annotations = decoder_model_config.quant_recipe().recipe.custom_quant_annotations

@cccclai
Copy link
Contributor Author

cccclai commented Nov 24, 2025

Fixed in a different PR

@cccclai cccclai closed this Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DannyYuyang-quic DannyYuyang-quic DannyYuyang-quic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cccclai @DannyYuyang-quic