Fix implicit float-to-double promotion. #15957
Open
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsharma35
requested review from
JacobSzwejbka,
lucylq and
manuelcandales
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15957
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87749870. |
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Nov 24, 2025
Summary: as titled Differential Revision: D87749870
hsharma35
force-pushed
the
export-D87749870
branch
from
7e4eabb to
7a9fff0
Compare
lucylq
reviewed
Nov 25, 2025
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Nov 25, 2025
Summary: as titled Differential Revision: D87749870
hsharma35
force-pushed
the
export-D87749870
branch
from
7a9fff0 to
97f4ca2
Compare
lucylq
approved these changes
Nov 25, 2025
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Nov 25, 2025
Summary: as titled Reviewed By: lucylq Differential Revision: D87749870
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Nov 25, 2025
Summary: as titled Reviewed By: lucylq Differential Revision: D87749870
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Nov 25, 2025
Summary: as titled Reviewed By: lucylq Differential Revision: D87749870
hsharma35
force-pushed
the
export-D87749870
branch
from
97f4ca2 to
305f6ff
Compare
Summary: as titled Reviewed By: lucylq Differential Revision: D87749870
hsharma35
force-pushed
the
export-D87749870
branch
from
305f6ff to
4c86377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: as titled
Differential Revision: D87749870