Adding a payload version to become compatible with new Neutron Converter #15959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15959
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
jirioc
requested review from
MartinPavella,
StrycekSimon and
roman-janik-nxp
jirioc
added
ciflow/trunk
module: nxp
| graph_outputs = sub_graph.OutputsAsNumpy() | ||
| payload_version = 0 | ||
| node_outputs = neutron_node.OutputsAsNumpy()[:-1] | ||
| if len(graph_outputs) == len(node_outputs) - 2: |
Collaborator
There was a problem hiding this comment.
Could you please add a comment explaining the - 2?
Collaborator
Author
There was a problem hiding this comment.
I added a comment explaining all 3 extra tensors.
MartinPavella
approved these changes
Nov 25, 2025
| assert payload[6] == 0x0 # Map 0-th Neutron output to 0-th model output | ||
| assert all(byte == 0x0 for byte in payload[7:16]) # Aligned to 16 bytes | ||
| assert ( | ||
| payload[7] == 0x0 or payload[7] == 0x1 |
Collaborator
There was a problem hiding this comment.
Do you think it would be useful to use NeutronTargetSpec to determine the expected payload version for a stricter check?
Collaborator
Author
There was a problem hiding this comment.
The payload version is not dependent on Target, it depends on neutron converter version.
jirioc
force-pushed
the
feature-eiex-640-update-payload-version
branch
3 times, most recently
from
6d6d328 to
70deb5e
Compare
jirioc
force-pushed
the
feature-eiex-640-update-payload-version
branch
from
70deb5e to
31306d1
Compare
roman-janik-nxp
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new neutron converter introduces extra output tensors. This requires changes in the backend. These changes are backward compatible, meaning that the PTE converted by the older versions can be run by the new NeutronBackend.cpp, but not vice versa.
Test plan
The unit tests have been adjusted to accommodate the new payload format.
cc @robert-kalmar @JakeStevens @digantdesai