Skip to content

Arm backend: Replace ±inf and FP limit values with ±255.0 #15976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Arm backend: Replace ±inf and FP limit values with ±255.0 #15976

wants to merge 1 commit into from
+13 −10

Conversation

@YufengShi-dudu
Copy link
Collaborator

@YufengShi-dudu YufengShi-dudu commented Nov 25, 2025 •
edited by pytorch-bot bot
Loading

  • Rename ReplaceInfValuesPass -> ReplaceInfAndLimitValuesPass
  • Extend to rewrite torch.finfo(torch.float32).{min,max} to ±255.0 to avoid generating TOSA RESCALE shifts < 2 (invalid per spec)

Change-Id: I749f7c28090c1e994ce27b19944db4c57f3b517d

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@YufengShi-dudu
Arm backend: Replace ±inf and FP limit values with ±255.0
55b918e 
- Rename ReplaceInfValuesPass -> ReplaceInfAndLimitValuesPass
- Extend to rewrite torch.finfo(torch.float32).{min,max} to ±255.0
  to avoid generating TOSA RESCALE shifts < 2 (invalid per spec)

Change-Id: I749f7c28090c1e994ce27b19944db4c57f3b517d
Signed-off-by: Yufeng Shi <[email protected]>
@YufengShi-dudu YufengShi-dudu added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Nov 25, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15976

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingo zingo Awaiting requested review from zingo

@mansnils mansnils Awaiting requested review from mansnils

@ArmRyan ArmRyan Awaiting requested review from ArmRyan

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@YufengShi-dudu