Arm backend: Add support for int32 clamp #15977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tosa does not support int32 dtype for clamp operator so instead we need to use Min/Max to implement clamp. Signed-off-by: Ryan O'Shea <[email protected]> Change-Id: Iea442901b2227610ebb5e5a0f1bca8d236e70d9d
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15977
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit caf8938 with merge base 2ed6d6a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
ArmRyan
added
partner: arm
oscarandersson8218
requested changes
Nov 25, 2025
Collaborator
oscarandersson8218
left a comment
oscarandersson8218
left a comment
There was a problem hiding this comment.
I think this should be done in a pass instead.
meta-cla
bot
added
the
CLA Signed
Signed-off-by: Ryan O'Shea <[email protected]> Change-Id: I6678a4da16854c03c2f820945007db901adbe923
Collaborator
Author
Done |
oscarandersson8218
approved these changes
Dec 2, 2025
Collaborator
oscarandersson8218
left a comment
oscarandersson8218
left a comment
There was a problem hiding this comment.
Failures seem unrelated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tosa does not support int32 dtype for clamp operator
so instead we need to use Min/Max to implement clamp.
Change-Id: Iea442901b2227610ebb5e5a0f1bca8d236e70d9d
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai