Refactor gather_test_model to be hard coded directly #9227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9227
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 26 Pending, 1 Unrelated FailureAs of commit af97aff with merge base 753da9a ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
mergennachin
force-pushed
the
refactor_ci_job
branch
from
b339b38 to
ef8d5d4
Compare
mergennachin
requested review from
kirklandsign,
guangy10,
jackzhxng and
swolchok
mergennachin
force-pushed
the
refactor_ci_job
branch
from
ef8d5d4 to
d57d66d
Compare
mergennachin
force-pushed
the
refactor_ci_job
branch
from
d57d66d to
177794d
Compare
mergennachin
force-pushed
the
refactor_ci_job
branch
2 times, most recently
from
831a115 to
0a6fcd5
Compare
mergennachin
force-pushed
the
refactor_ci_job
branch
from
0a6fcd5 to
af97aff
Compare
malfet
approved these changes
Mar 13, 2025
jackzhxng
reviewed
Mar 13, 2025
|
Yeah, you can use include and exclude logic directly in the matrix The example you provided works. |
|
One thing that I realized I had a bug. The include statements should define all the variables. |
mergennachin
added a commit
that referenced
this pull request
Mar 13, 2025
Fixing #9227, It wasn't running efficient_sam, llama etc. Because I had to define all variables in the include statement. Since build-tool and runner are singletons, I just hard code it. Test Plan: Make sure trunk jobs have softmax, efficient_sam etc.
mergennachin
added a commit
that referenced
this pull request
Mar 13, 2025
Fixing #9227 matrix.timeout is not populated. Just hard-code the value now. Also fix another cleanup DEMO_BACKEND_ID is not there anymore. Test Plan: Make sure there are 6 jobs (test-models-linux) in the pull.yml category.
mergennachin
added a commit
that referenced
this pull request
Mar 13, 2025
Looks like I lied when I said #9227 was a no-op Adding back pull jobs for linux x86
mergennachin
added a commit
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI runner logic should directly be in the corresponding yml files.
Gather_test_models.py contains overly complicated python logic on what models, backends, runners to do, with many switch statements.
I think we should just hard code directly in job descriptions to simplify things and know exactly what jobs are running directly in the yml file.
This is a no-op PR