[BE] Introduce lapack_work_to_int function
#149682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malfet
requested review from
lezcano,
nikitaved and
IvanYashchuk
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149682
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0496b6d with merge base a268c29 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
added
release notes: linalg_frontend
wdvr
approved these changes
Mar 20, 2025
malfet
changed the title
lapack_work_to_int function
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
svekars
pushed a commit
that referenced
this pull request
Mar 21, 2025
That could be used to safely cast floating values to int by adding an ULP, which is a followup after #146456 Fixes #149591 (Not adding unittest as it's just going to be too slow) Test plan: ``` % python3 -c "import torch; torch.pinverse(torch.rand(50000, 8193))" ``` Before the change errored out with ``` RuntimeError: false INTERNAL ASSERT FAILED at "pytorch/pytorch/aten/src/ATen/native/BatchLinearAlgebra.cpp":1605, please report a bug to PyTorch. linalg.svd: Argument 12 has illegal value. Most certainly there is a bug in the implementation calling the backend library. ``` Pull Request resolved: #149682 Approved by: https://github.com/wdvr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That could be used to safely cast floating values to int by adding an ULP, which is a followup after #146456
Fixes #149591
(Not adding unittest as it's just going to be too slow)
Test plan:
Before the change errored out with