Skip to content

[BugFix] Fix batch_locked check in check_env_specs + error message callable #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 3, 2025
Merged

[BugFix] Fix batch_locked check in check_env_specs + error message callable #2817

merged 5 commits into from
Mar 3, 2025

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 28, 2025 •
edited
Loading

@vmoens
Update
ed5d500 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2817

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 70da33a with merge base 8c9dc05 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Feb 3, 2025
Merged
Merged
Merged
Merged
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2025
@vmoens
Update
7b94e42 
[ghstack-poisoned]
@vmoens
Update
f4f88fb 
[ghstack-poisoned]
@vmoens vmoens added the bug Something isn't working label Feb 28, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 149. Improved: $\large\color{#35bf28}10$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.6257s 0.5278s 1.8946 Ops/s 1.9316 Ops/s $\color{#d91a1a}-1.92\%$
test_transformed 1.1343s 1.0310s 0.9699 Ops/s 0.9557 Ops/s $\color{#35bf28}+1.48\%$
test_serial 1.6160s 1.5252s 0.6556 Ops/s 0.6466 Ops/s $\color{#35bf28}+1.40\%$
test_parallel 1.3914s 1.2961s 0.7715 Ops/s 0.7587 Ops/s $\color{#35bf28}+1.70\%$
test_step_mdp_speed[True-True-True-True-True] 0.1947ms 30.1554μs 33.1615 KOps/s 33.2475 KOps/s $\color{#d91a1a}-0.26\%$
test_step_mdp_speed[True-True-True-True-False] 48.4600μs 17.9644μs 55.6657 KOps/s 56.0657 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[True-True-True-False-True] 73.8880μs 16.9622μs 58.9546 KOps/s 58.7177 KOps/s $\color{#35bf28}+0.40\%$
test_step_mdp_speed[True-True-True-False-False] 34.2230μs 10.0962μs 99.0469 KOps/s 99.3782 KOps/s $\color{#d91a1a}-0.33\%$
test_step_mdp_speed[True-True-False-True-True] 88.4050μs 32.0594μs 31.1921 KOps/s 31.3550 KOps/s $\color{#d91a1a}-0.52\%$
test_step_mdp_speed[True-True-False-True-False] 68.4480μs 19.8545μs 50.3663 KOps/s 50.8576 KOps/s $\color{#d91a1a}-0.97\%$
test_step_mdp_speed[True-True-False-False-True] 59.9920μs 18.9688μs 52.7182 KOps/s 52.5741 KOps/s $\color{#35bf28}+0.27\%$
test_step_mdp_speed[True-True-False-False-False] 64.0790μs 12.1564μs 82.2609 KOps/s 83.2867 KOps/s $\color{#d91a1a}-1.23\%$
test_step_mdp_speed[True-False-True-True-True] 62.2060μs 34.2140μs 29.2278 KOps/s 29.4123 KOps/s $\color{#d91a1a}-0.63\%$
test_step_mdp_speed[True-False-True-True-False] 0.6928ms 21.6440μs 46.2022 KOps/s 46.3593 KOps/s $\color{#d91a1a}-0.34\%$
test_step_mdp_speed[True-False-True-False-True] 63.7190μs 18.8085μs 53.1674 KOps/s 52.7438 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[True-False-True-False-False] 61.4040μs 11.9007μs 84.0286 KOps/s 84.3859 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[True-False-False-True-True] 84.2160μs 35.8810μs 27.8699 KOps/s 27.8671 KOps/s $\color{#35bf28}+0.01\%$
test_step_mdp_speed[True-False-False-True-False] 78.1760μs 23.4252μs 42.6891 KOps/s 43.1173 KOps/s $\color{#d91a1a}-0.99\%$
test_step_mdp_speed[True-False-False-False-True] 60.0320μs 20.5430μs 48.6783 KOps/s 48.9206 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[True-False-False-False-False] 61.6550μs 13.7225μs 72.8732 KOps/s 73.0362 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[False-True-True-True-True] 0.1003ms 34.1987μs 29.2409 KOps/s 29.4110 KOps/s $\color{#d91a1a}-0.58\%$
test_step_mdp_speed[False-True-True-True-False] 55.5740μs 21.8143μs 45.8415 KOps/s 45.8312 KOps/s $\color{#35bf28}+0.02\%$
test_step_mdp_speed[False-True-True-False-True] 71.1030μs 21.5677μs 46.3657 KOps/s 46.1072 KOps/s $\color{#35bf28}+0.56\%$
test_step_mdp_speed[False-True-True-False-False] 41.6370μs 13.5444μs 73.8311 KOps/s 74.0450 KOps/s $\color{#d91a1a}-0.29\%$
test_step_mdp_speed[False-True-False-True-True] 0.1136ms 35.8339μs 27.9065 KOps/s 27.4258 KOps/s $\color{#35bf28}+1.75\%$
test_step_mdp_speed[False-True-False-True-False] 55.6240μs 23.4829μs 42.5843 KOps/s 42.9248 KOps/s $\color{#d91a1a}-0.79\%$
test_step_mdp_speed[False-True-False-False-True] 2.4135ms 23.1582μs 43.1812 KOps/s 43.0036 KOps/s $\color{#35bf28}+0.41\%$
test_step_mdp_speed[False-True-False-False-False] 61.7650μs 15.1579μs 65.9722 KOps/s 66.5472 KOps/s $\color{#d91a1a}-0.86\%$
test_step_mdp_speed[False-False-True-True-True] 93.1930μs 37.2980μs 26.8111 KOps/s 26.7883 KOps/s $\color{#35bf28}+0.08\%$
test_step_mdp_speed[False-False-True-True-False] 80.1490μs 25.4731μs 39.2570 KOps/s 39.5106 KOps/s $\color{#d91a1a}-0.64\%$
test_step_mdp_speed[False-False-True-False-True] 48.6600μs 23.2996μs 42.9192 KOps/s 43.0057 KOps/s $\color{#d91a1a}-0.20\%$
test_step_mdp_speed[False-False-True-False-False] 0.6620ms 15.0884μs 66.2762 KOps/s 66.1830 KOps/s $\color{#35bf28}+0.14\%$
test_step_mdp_speed[False-False-False-True-True] 84.9490μs 39.0004μs 25.6408 KOps/s 25.7006 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[False-False-False-True-False] 0.1119ms 27.5117μs 36.3482 KOps/s 36.7435 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[False-False-False-False-True] 84.1570μs 25.0633μs 39.8990 KOps/s 39.9863 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[False-False-False-False-False] 42.7400μs 16.8599μs 59.3122 KOps/s 59.5905 KOps/s $\color{#d91a1a}-0.47\%$
test_values[generalized_advantage_estimate-True-True] 9.9447ms 9.6653ms 103.4634 Ops/s 103.4774 Ops/s $\color{#d91a1a}-0.01\%$
test_values[vec_generalized_advantage_estimate-True-True] 26.6790ms 24.3289ms 41.1033 Ops/s 37.3375 Ops/s $\textbf{\color{#35bf28}+10.09\%}$
test_values[td0_return_estimate-False-False] 0.2346ms 0.1804ms 5.5429 KOps/s 5.2808 KOps/s $\color{#35bf28}+4.96\%$
test_values[td1_return_estimate-False-False] 26.7089ms 24.2759ms 41.1932 Ops/s 41.6798 Ops/s $\color{#d91a1a}-1.17\%$
test_values[vec_td1_return_estimate-False-False] 26.0596ms 24.3653ms 41.0419 Ops/s 36.3534 Ops/s $\textbf{\color{#35bf28}+12.90\%}$
test_values[td_lambda_return_estimate-True-False] 35.3974ms 34.8056ms 28.7310 Ops/s 28.1022 Ops/s $\color{#35bf28}+2.24\%$
test_values[vec_td_lambda_return_estimate-True-False] 27.4164ms 24.5721ms 40.6966 Ops/s 36.4733 Ops/s $\textbf{\color{#35bf28}+11.58\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.8292ms 8.4249ms 118.6963 Ops/s 120.1364 Ops/s $\color{#d91a1a}-1.20\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.2292ms 1.9091ms 523.8002 Ops/s 511.3801 Ops/s $\color{#35bf28}+2.43\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4635ms 0.3638ms 2.7487 KOps/s 2.7847 KOps/s $\color{#d91a1a}-1.29\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 45.9985ms 42.9329ms 23.2922 Ops/s 22.7100 Ops/s $\color{#35bf28}+2.56\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.8335ms 3.4549ms 289.4467 Ops/s 289.2184 Ops/s $\color{#35bf28}+0.08\%$
test_dqn_speed[False-None] 5.6848ms 1.4286ms 700.0016 Ops/s 704.7819 Ops/s $\color{#d91a1a}-0.68\%$
test_dqn_speed[False-backward] 1.9844ms 1.9015ms 525.9001 Ops/s 525.9260 Ops/s $-0.00\%$
test_dqn_speed[True-None] 0.7569ms 0.4735ms 2.1120 KOps/s 2.0717 KOps/s $\color{#35bf28}+1.95\%$
test_dqn_speed[True-backward] 1.1841ms 0.9386ms 1.0655 KOps/s 973.3499 Ops/s $\textbf{\color{#35bf28}+9.46\%}$
test_dqn_speed[reduce-overhead-None] 0.6493ms 0.4784ms 2.0902 KOps/s 2.0389 KOps/s $\color{#35bf28}+2.51\%$
test_dqn_speed[reduce-overhead-backward] 0.9386ms 0.8944ms 1.1181 KOps/s 1.0961 KOps/s $\color{#35bf28}+2.00\%$
test_ddpg_speed[False-None] 4.0621ms 2.9119ms 343.4138 Ops/s 339.6110 Ops/s $\color{#35bf28}+1.12\%$
test_ddpg_speed[False-backward] 4.2296ms 4.0319ms 248.0196 Ops/s 246.8798 Ops/s $\color{#35bf28}+0.46\%$
test_ddpg_speed[True-None] 1.8435ms 1.2454ms 802.9227 Ops/s 809.0841 Ops/s $\color{#d91a1a}-0.76\%$
test_ddpg_speed[True-backward] 2.2108ms 2.1240ms 470.8080 Ops/s 453.9405 Ops/s $\color{#35bf28}+3.72\%$
test_ddpg_speed[reduce-overhead-None] 1.4532ms 1.2244ms 816.7118 Ops/s 800.3734 Ops/s $\color{#35bf28}+2.04\%$
test_ddpg_speed[reduce-overhead-backward] 2.2094ms 2.1310ms 469.2610 Ops/s 458.5154 Ops/s $\color{#35bf28}+2.34\%$
test_sac_speed[False-None] 9.0134ms 8.0727ms 123.8736 Ops/s 122.7246 Ops/s $\color{#35bf28}+0.94\%$
test_sac_speed[False-backward] 12.5482ms 10.9334ms 91.4625 Ops/s 92.0979 Ops/s $\color{#d91a1a}-0.69\%$
test_sac_speed[True-None] 2.8699ms 2.1391ms 467.4793 Ops/s 464.8669 Ops/s $\color{#35bf28}+0.56\%$
test_sac_speed[True-backward] 3.8857ms 3.7796ms 264.5760 Ops/s 255.2960 Ops/s $\color{#35bf28}+3.63\%$
test_sac_speed[reduce-overhead-None] 2.7890ms 2.1017ms 475.8137 Ops/s 460.9695 Ops/s $\color{#35bf28}+3.22\%$
test_sac_speed[reduce-overhead-backward] 3.8919ms 3.7996ms 263.1858 Ops/s 257.9085 Ops/s $\color{#35bf28}+2.05\%$
test_redq_speed[False-None] 15.5682ms 13.6437ms 73.2940 Ops/s 74.1728 Ops/s $\color{#d91a1a}-1.18\%$
test_redq_speed[False-backward] 24.8588ms 22.8841ms 43.6985 Ops/s 40.6340 Ops/s $\textbf{\color{#35bf28}+7.54\%}$
test_redq_speed[True-None] 5.8914ms 5.0931ms 196.3445 Ops/s 186.3930 Ops/s $\textbf{\color{#35bf28}+5.34\%}$
test_redq_speed[True-backward] 13.5976ms 12.7530ms 78.4130 Ops/s 75.3605 Ops/s $\color{#35bf28}+4.05\%$
test_redq_speed[reduce-overhead-None] 6.6786ms 5.3827ms 185.7802 Ops/s 187.4443 Ops/s $\color{#d91a1a}-0.89\%$
test_redq_speed[reduce-overhead-backward] 13.1550ms 12.6952ms 78.7698 Ops/s 73.5511 Ops/s $\textbf{\color{#35bf28}+7.10\%}$
test_redq_deprec_speed[False-None] 16.1737ms 13.1445ms 76.0777 Ops/s 75.4293 Ops/s $\color{#35bf28}+0.86\%$
test_redq_deprec_speed[False-backward] 20.9344ms 19.2705ms 51.8928 Ops/s 51.7873 Ops/s $\color{#35bf28}+0.20\%$
test_redq_deprec_speed[True-None] 5.0075ms 4.1332ms 241.9458 Ops/s 244.4055 Ops/s $\color{#d91a1a}-1.01\%$
test_redq_deprec_speed[True-backward] 9.2061ms 8.4568ms 118.2474 Ops/s 108.1624 Ops/s $\textbf{\color{#35bf28}+9.32\%}$
test_redq_deprec_speed[reduce-overhead-None] 4.7689ms 3.9119ms 255.6327 Ops/s 244.6056 Ops/s $\color{#35bf28}+4.51\%$
test_redq_deprec_speed[reduce-overhead-backward] 10.1139ms 8.7093ms 114.8198 Ops/s 108.4178 Ops/s $\textbf{\color{#35bf28}+5.90\%}$
test_td3_speed[False-None] 8.7998ms 8.1426ms 122.8104 Ops/s 120.4846 Ops/s $\color{#35bf28}+1.93\%$
test_td3_speed[False-backward] 11.2328ms 10.5120ms 95.1291 Ops/s 94.1807 Ops/s $\color{#35bf28}+1.01\%$
test_td3_speed[True-None] 1.8747ms 1.7638ms 566.9427 Ops/s 542.7825 Ops/s $\color{#35bf28}+4.45\%$
test_td3_speed[True-backward] 4.4332ms 3.4164ms 292.7054 Ops/s 280.5455 Ops/s $\color{#35bf28}+4.33\%$
test_td3_speed[reduce-overhead-None] 1.9082ms 1.7692ms 565.2261 Ops/s 544.2109 Ops/s $\color{#35bf28}+3.86\%$
test_td3_speed[reduce-overhead-backward] 3.5370ms 3.4030ms 293.8615 Ops/s 290.4996 Ops/s $\color{#35bf28}+1.16\%$
test_cql_speed[False-None] 40.2626ms 36.8311ms 27.1509 Ops/s 26.9741 Ops/s $\color{#35bf28}+0.66\%$
test_cql_speed[False-backward] 51.6363ms 47.5391ms 21.0353 Ops/s 20.8859 Ops/s $\color{#35bf28}+0.72\%$
test_cql_speed[True-None] 17.6744ms 16.1966ms 61.7413 Ops/s 60.5429 Ops/s $\color{#35bf28}+1.98\%$
test_cql_speed[True-backward] 23.8998ms 23.1745ms 43.1510 Ops/s 42.2035 Ops/s $\color{#35bf28}+2.24\%$
test_cql_speed[reduce-overhead-None] 17.5217ms 16.2873ms 61.3975 Ops/s 60.4064 Ops/s $\color{#35bf28}+1.64\%$
test_cql_speed[reduce-overhead-backward] 24.7613ms 23.3153ms 42.8903 Ops/s 42.0801 Ops/s $\color{#35bf28}+1.93\%$
test_a2c_speed[False-None] 9.0626ms 7.3042ms 136.9076 Ops/s 135.3377 Ops/s $\color{#35bf28}+1.16\%$
test_a2c_speed[False-backward] 16.3293ms 14.6509ms 68.2550 Ops/s 66.7323 Ops/s $\color{#35bf28}+2.28\%$
test_a2c_speed[True-None] 4.0780ms 3.7064ms 269.8019 Ops/s 267.1198 Ops/s $\color{#35bf28}+1.00\%$
test_a2c_speed[True-backward] 11.5324ms 10.4119ms 96.0438 Ops/s 95.6436 Ops/s $\color{#35bf28}+0.42\%$
test_a2c_speed[reduce-overhead-None] 4.1346ms 3.6940ms 270.7077 Ops/s 262.6760 Ops/s $\color{#35bf28}+3.06\%$
test_a2c_speed[reduce-overhead-backward] 12.3512ms 10.4831ms 95.3914 Ops/s 95.6530 Ops/s $\color{#d91a1a}-0.27\%$
test_ppo_speed[False-None] 9.3691ms 7.5836ms 131.8640 Ops/s 130.7932 Ops/s $\color{#35bf28}+0.82\%$
test_ppo_speed[False-backward] 15.7682ms 15.2361ms 65.6335 Ops/s 65.3576 Ops/s $\color{#35bf28}+0.42\%$
test_ppo_speed[True-None] 4.4273ms 4.0782ms 245.2081 Ops/s 238.9349 Ops/s $\color{#35bf28}+2.63\%$
test_ppo_speed[True-backward] 10.9255ms 10.2554ms 97.5091 Ops/s 99.5230 Ops/s $\color{#d91a1a}-2.02\%$
test_ppo_speed[reduce-overhead-None] 4.5209ms 4.1845ms 238.9747 Ops/s 239.4126 Ops/s $\color{#d91a1a}-0.18\%$
test_ppo_speed[reduce-overhead-backward] 10.6257ms 10.1028ms 98.9827 Ops/s 96.5948 Ops/s $\color{#35bf28}+2.47\%$
test_reinforce_speed[False-None] 7.2253ms 6.5887ms 151.7753 Ops/s 147.8477 Ops/s $\color{#35bf28}+2.66\%$
test_reinforce_speed[False-backward] 11.6851ms 10.0133ms 99.8676 Ops/s 98.1573 Ops/s $\color{#35bf28}+1.74\%$
test_reinforce_speed[True-None] 3.8391ms 3.1164ms 320.8787 Ops/s 316.6499 Ops/s $\color{#35bf28}+1.34\%$
test_reinforce_speed[True-backward] 9.6368ms 9.1409ms 109.3988 Ops/s 107.5897 Ops/s $\color{#35bf28}+1.68\%$
test_reinforce_speed[reduce-overhead-None] 4.0026ms 3.0770ms 324.9876 Ops/s 317.9393 Ops/s $\color{#35bf28}+2.22\%$
test_reinforce_speed[reduce-overhead-backward] 10.3362ms 9.1461ms 109.3360 Ops/s 109.1872 Ops/s $\color{#35bf28}+0.14\%$
test_iql_speed[False-None] 34.1209ms 32.4399ms 30.8262 Ops/s 30.3321 Ops/s $\color{#35bf28}+1.63\%$
test_iql_speed[False-backward] 52.9237ms 45.8870ms 21.7927 Ops/s 21.7195 Ops/s $\color{#35bf28}+0.34\%$
test_iql_speed[True-None] 12.6696ms 11.6678ms 85.7058 Ops/s 83.9562 Ops/s $\color{#35bf28}+2.08\%$
test_iql_speed[True-backward] 27.5450ms 23.1946ms 43.1135 Ops/s 43.1697 Ops/s $\color{#d91a1a}-0.13\%$
test_iql_speed[reduce-overhead-None] 13.3912ms 11.6648ms 85.7281 Ops/s 83.6175 Ops/s $\color{#35bf28}+2.52\%$
test_iql_speed[reduce-overhead-backward] 24.1887ms 22.9865ms 43.5038 Ops/s 42.5767 Ops/s $\color{#35bf28}+2.18\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.7301ms 4.8988ms 204.1325 Ops/s 203.1332 Ops/s $\color{#35bf28}+0.49\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7693ms 0.5210ms 1.9193 KOps/s 1.9064 KOps/s $\color{#35bf28}+0.68\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8097ms 0.5035ms 1.9859 KOps/s 2.0076 KOps/s $\color{#d91a1a}-1.08\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 7.3977ms 4.7546ms 210.3213 Ops/s 212.0072 Ops/s $\color{#d91a1a}-0.80\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 3.0093ms 0.5122ms 1.9522 KOps/s 1.9328 KOps/s $\color{#35bf28}+1.01\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8247ms 0.4896ms 2.0427 KOps/s 2.0099 KOps/s $\color{#35bf28}+1.63\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.4999ms 1.6637ms 601.0559 Ops/s 602.7809 Ops/s $\color{#d91a1a}-0.29\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.2260ms 1.5729ms 635.7780 Ops/s 629.8046 Ops/s $\color{#35bf28}+0.95\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.2892ms 4.7732ms 209.5051 Ops/s 205.5738 Ops/s $\color{#35bf28}+1.91\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.8824ms 0.6571ms 1.5218 KOps/s 1.5163 KOps/s $\color{#35bf28}+0.36\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8441ms 0.6263ms 1.5967 KOps/s 1.5699 KOps/s $\color{#35bf28}+1.70\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.9585ms 4.6858ms 213.4125 Ops/s 209.8382 Ops/s $\color{#35bf28}+1.70\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 3.0458ms 0.5180ms 1.9305 KOps/s 1.9011 KOps/s $\color{#35bf28}+1.55\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7795ms 0.4970ms 2.0120 KOps/s 1.9990 KOps/s $\color{#35bf28}+0.65\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 7.3342ms 4.7519ms 210.4401 Ops/s 214.3755 Ops/s $\color{#d91a1a}-1.84\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8467ms 0.5138ms 1.9461 KOps/s 1.8807 KOps/s $\color{#35bf28}+3.48\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7175ms 0.4906ms 2.0385 KOps/s 2.0455 KOps/s $\color{#d91a1a}-0.34\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.6168ms 5.1496ms 194.1882 Ops/s 211.7835 Ops/s $\textbf{\color{#d91a1a}-8.31\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 3.8012ms 0.6660ms 1.5015 KOps/s 1.5253 KOps/s $\color{#d91a1a}-1.56\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8997ms 0.6360ms 1.5723 KOps/s 1.5747 KOps/s $\color{#d91a1a}-0.15\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 8.1978ms 4.4225ms 226.1141 Ops/s 247.4448 Ops/s $\textbf{\color{#d91a1a}-8.62\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 3.5076ms 2.2813ms 438.3380 Ops/s 442.6578 Ops/s $\color{#d91a1a}-0.98\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.3582ms 1.4906ms 670.8621 Ops/s 710.7925 Ops/s $\textbf{\color{#d91a1a}-5.62\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.4907s 14.1375ms 70.7339 Ops/s 236.4907 Ops/s $\textbf{\color{#d91a1a}-70.09\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 9.3374ms 2.3425ms 426.8876 Ops/s 425.2951 Ops/s $\color{#35bf28}+0.37\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.4978ms 1.4832ms 674.2058 Ops/s 688.5999 Ops/s $\color{#d91a1a}-2.09\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 6.8082ms 4.6457ms 215.2545 Ops/s 31.5697 Ops/s $\textbf{\color{#35bf28}+581.84\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 7.6871ms 2.4829ms 402.7562 Ops/s 397.6750 Ops/s $\color{#35bf28}+1.28\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.9392ms 1.5604ms 640.8563 Ops/s 617.7931 Ops/s $\color{#35bf28}+3.73\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 12.4663ms 11.9783ms 83.4846 Ops/s 79.5965 Ops/s $\color{#35bf28}+4.88\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 15.5454ms 14.3632ms 69.6224 Ops/s 70.2757 Ops/s $\color{#d91a1a}-0.93\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 21.3210ms 20.7610ms 48.1673 Ops/s 46.3939 Ops/s $\color{#35bf28}+3.82\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 15.7195ms 14.4225ms 69.3361 Ops/s 68.1817 Ops/s $\color{#35bf28}+1.69\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 23.5937ms 21.0254ms 47.5616 Ops/s 47.0648 Ops/s $\color{#35bf28}+1.06\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 18.3552ms 15.8989ms 62.8976 Ops/s 63.2511 Ops/s $\color{#d91a1a}-0.56\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 149. Improved: $\large\color{#35bf28}26$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.8966s 0.8112s 1.2327 Ops/s 1.1851 Ops/s $\color{#35bf28}+4.02\%$
test_transformed 1.4936s 1.4085s 0.7100 Ops/s 0.6692 Ops/s $\textbf{\color{#35bf28}+6.10\%}$
test_serial 2.3847s 2.3007s 0.4347 Ops/s 0.4192 Ops/s $\color{#35bf28}+3.68\%$
test_parallel 1.9310s 1.8658s 0.5359 Ops/s 0.5309 Ops/s $\color{#35bf28}+0.94\%$
test_step_mdp_speed[True-True-True-True-True] 0.1745ms 41.4612μs 24.1189 KOps/s 24.1009 KOps/s $\color{#35bf28}+0.07\%$
test_step_mdp_speed[True-True-True-True-False] 0.1405ms 24.2579μs 41.2237 KOps/s 40.9852 KOps/s $\color{#35bf28}+0.58\%$
test_step_mdp_speed[True-True-True-False-True] 0.6260ms 23.6716μs 42.2447 KOps/s 43.9213 KOps/s $\color{#d91a1a}-3.82\%$
test_step_mdp_speed[True-True-True-False-False] 37.3610μs 13.3791μs 74.7432 KOps/s 76.0299 KOps/s $\color{#d91a1a}-1.69\%$
test_step_mdp_speed[True-True-False-True-True] 0.1001ms 43.8828μs 22.7880 KOps/s 22.4915 KOps/s $\color{#35bf28}+1.32\%$
test_step_mdp_speed[True-True-False-True-False] 58.8610μs 26.2960μs 38.0286 KOps/s 37.8417 KOps/s $\color{#35bf28}+0.49\%$
test_step_mdp_speed[True-True-False-False-True] 0.1162ms 25.3372μs 39.4676 KOps/s 39.5187 KOps/s $\color{#d91a1a}-0.13\%$
test_step_mdp_speed[True-True-False-False-False] 0.1454ms 15.7618μs 63.4443 KOps/s 62.7163 KOps/s $\color{#35bf28}+1.16\%$
test_step_mdp_speed[True-False-True-True-True] 80.1810μs 45.9582μs 21.7589 KOps/s 21.5464 KOps/s $\color{#35bf28}+0.99\%$
test_step_mdp_speed[True-False-True-True-False] 88.4120μs 28.9399μs 34.5544 KOps/s 34.6714 KOps/s $\color{#d91a1a}-0.34\%$
test_step_mdp_speed[True-False-True-False-True] 59.8410μs 25.5528μs 39.1346 KOps/s 39.3691 KOps/s $\color{#d91a1a}-0.60\%$
test_step_mdp_speed[True-False-True-False-False] 0.1686ms 15.9017μs 62.8863 KOps/s 63.5570 KOps/s $\color{#d91a1a}-1.06\%$
test_step_mdp_speed[True-False-False-True-True] 0.1818ms 47.9705μs 20.8462 KOps/s 20.4695 KOps/s $\color{#35bf28}+1.84\%$
test_step_mdp_speed[True-False-False-True-False] 66.5610μs 31.2397μs 32.0106 KOps/s 32.5454 KOps/s $\color{#d91a1a}-1.64\%$
test_step_mdp_speed[True-False-False-False-True] 88.7520μs 27.3036μs 36.6252 KOps/s 36.3478 KOps/s $\color{#35bf28}+0.76\%$
test_step_mdp_speed[True-False-False-False-False] 0.2037ms 17.7845μs 56.2288 KOps/s 56.0425 KOps/s $\color{#35bf28}+0.33\%$
test_step_mdp_speed[False-True-True-True-True] 0.2337ms 45.6059μs 21.9270 KOps/s 21.7374 KOps/s $\color{#35bf28}+0.87\%$
test_step_mdp_speed[False-True-True-True-False] 0.1192ms 28.7641μs 34.7656 KOps/s 35.5532 KOps/s $\color{#d91a1a}-2.22\%$
test_step_mdp_speed[False-True-True-False-True] 0.1092ms 29.5995μs 33.7843 KOps/s 34.2978 KOps/s $\color{#d91a1a}-1.50\%$
test_step_mdp_speed[False-True-True-False-False] 43.7700μs 17.5579μs 56.9543 KOps/s 56.7120 KOps/s $\color{#35bf28}+0.43\%$
test_step_mdp_speed[False-True-False-True-True] 96.2610μs 48.2902μs 20.7081 KOps/s 20.9114 KOps/s $\color{#d91a1a}-0.97\%$
test_step_mdp_speed[False-True-False-True-False] 67.7910μs 30.7610μs 32.5087 KOps/s 32.9680 KOps/s $\color{#d91a1a}-1.39\%$
test_step_mdp_speed[False-True-False-False-True] 3.0282ms 32.2120μs 31.0443 KOps/s 32.0457 KOps/s $\color{#d91a1a}-3.12\%$
test_step_mdp_speed[False-True-False-False-False] 0.1450ms 19.9268μs 50.1837 KOps/s 51.2906 KOps/s $\color{#d91a1a}-2.16\%$
test_step_mdp_speed[False-False-True-True-True] 97.8010μs 51.0960μs 19.5710 KOps/s 19.7054 KOps/s $\color{#d91a1a}-0.68\%$
test_step_mdp_speed[False-False-True-True-False] 63.1610μs 33.6843μs 29.6874 KOps/s 30.6238 KOps/s $\color{#d91a1a}-3.06\%$
test_step_mdp_speed[False-False-True-False-True] 63.0320μs 31.6905μs 31.5552 KOps/s 31.9794 KOps/s $\color{#d91a1a}-1.33\%$
test_step_mdp_speed[False-False-True-False-False] 51.0410μs 19.7487μs 50.6361 KOps/s 50.1901 KOps/s $\color{#35bf28}+0.89\%$
test_step_mdp_speed[False-False-False-True-True] 0.1073ms 52.8901μs 18.9071 KOps/s 18.9509 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[False-False-False-True-False] 69.3320μs 35.7983μs 27.9343 KOps/s 29.1681 KOps/s $\color{#d91a1a}-4.23\%$
test_step_mdp_speed[False-False-False-False-True] 0.1230ms 33.2428μs 30.0817 KOps/s 30.5174 KOps/s $\color{#d91a1a}-1.43\%$
test_step_mdp_speed[False-False-False-False-False] 0.1006ms 21.8821μs 45.6995 KOps/s 45.5758 KOps/s $\color{#35bf28}+0.27\%$
test_values[generalized_advantage_estimate-True-True] 26.2211ms 25.3683ms 39.4193 Ops/s 37.8582 Ops/s $\color{#35bf28}+4.12\%$
test_values[vec_generalized_advantage_estimate-True-True] 0.1007s 2.9192ms 342.5557 Ops/s 336.9787 Ops/s $\color{#35bf28}+1.66\%$
test_values[td0_return_estimate-False-False] 0.1056ms 79.7896μs 12.5330 KOps/s 12.5548 KOps/s $\color{#d91a1a}-0.17\%$
test_values[td1_return_estimate-False-False] 57.8741ms 56.1655ms 17.8045 Ops/s 17.3399 Ops/s $\color{#35bf28}+2.68\%$
test_values[vec_td1_return_estimate-False-False] 1.3048ms 1.0835ms 922.9474 Ops/s 912.1002 Ops/s $\color{#35bf28}+1.19\%$
test_values[td_lambda_return_estimate-True-False] 89.5362ms 88.3101ms 11.3237 Ops/s 10.8081 Ops/s $\color{#35bf28}+4.77\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.2861ms 1.0781ms 927.5247 Ops/s 921.3610 Ops/s $\color{#35bf28}+0.67\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.3715ms 24.8498ms 40.2418 Ops/s 38.9264 Ops/s $\color{#35bf28}+3.38\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.0227ms 0.7583ms 1.3187 KOps/s 1.3181 KOps/s $\color{#35bf28}+0.05\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.8597ms 0.6771ms 1.4768 KOps/s 1.4454 KOps/s $\color{#35bf28}+2.18\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.6356ms 1.4916ms 670.4158 Ops/s 671.3280 Ops/s $\color{#d91a1a}-0.14\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.8338ms 0.6838ms 1.4625 KOps/s 1.4580 KOps/s $\color{#35bf28}+0.31\%$
test_dqn_speed[False-None] 1.6461ms 1.4800ms 675.6814 Ops/s 662.7900 Ops/s $\color{#35bf28}+1.95\%$
test_dqn_speed[False-backward] 2.2792ms 2.0957ms 477.1638 Ops/s 470.5182 Ops/s $\color{#35bf28}+1.41\%$
test_dqn_speed[True-None] 0.7137ms 0.5508ms 1.8156 KOps/s 1.7693 KOps/s $\color{#35bf28}+2.61\%$
test_dqn_speed[True-backward] 1.3744ms 1.2294ms 813.3950 Ops/s 875.1678 Ops/s $\textbf{\color{#d91a1a}-7.06\%}$
test_dqn_speed[reduce-overhead-None] 0.7722ms 0.5743ms 1.7411 KOps/s 1.7579 KOps/s $\color{#d91a1a}-0.96\%$
test_dqn_speed[reduce-overhead-backward] 1.0170ms 0.9640ms 1.0374 KOps/s 925.2970 Ops/s $\textbf{\color{#35bf28}+12.11\%}$
test_ddpg_speed[False-None] 3.2562ms 2.8577ms 349.9289 Ops/s 352.5030 Ops/s $\color{#d91a1a}-0.73\%$
test_ddpg_speed[False-backward] 4.4711ms 4.0595ms 246.3328 Ops/s 233.3522 Ops/s $\textbf{\color{#35bf28}+5.56\%}$
test_ddpg_speed[True-None] 1.4887ms 1.3354ms 748.8444 Ops/s 745.4597 Ops/s $\color{#35bf28}+0.45\%$
test_ddpg_speed[True-backward] 2.4621ms 2.4254ms 412.2998 Ops/s 406.9891 Ops/s $\color{#35bf28}+1.30\%$
test_ddpg_speed[reduce-overhead-None] 1.5105ms 1.3487ms 741.4770 Ops/s 740.6189 Ops/s $\color{#35bf28}+0.12\%$
test_ddpg_speed[reduce-overhead-backward] 2.0403ms 1.9060ms 524.6603 Ops/s 523.0655 Ops/s $\color{#35bf28}+0.30\%$
test_sac_speed[False-None] 8.3744ms 7.9912ms 125.1371 Ops/s 121.9832 Ops/s $\color{#35bf28}+2.59\%$
test_sac_speed[False-backward] 11.4513ms 10.9384ms 91.4214 Ops/s 90.2425 Ops/s $\color{#35bf28}+1.31\%$
test_sac_speed[True-None] 2.1092ms 1.8492ms 540.7615 Ops/s 539.9923 Ops/s $\color{#35bf28}+0.14\%$
test_sac_speed[True-backward] 3.9968ms 3.7721ms 265.1057 Ops/s 269.1660 Ops/s $\color{#d91a1a}-1.51\%$
test_sac_speed[reduce-overhead-None] 21.6484ms 11.9903ms 83.4007 Ops/s 82.3453 Ops/s $\color{#35bf28}+1.28\%$
test_sac_speed[reduce-overhead-backward] 1.7291ms 1.6006ms 624.7696 Ops/s 608.1262 Ops/s $\color{#35bf28}+2.74\%$
test_redq_speed[False-None] 8.0579ms 7.5812ms 131.9047 Ops/s 127.3829 Ops/s $\color{#35bf28}+3.55\%$
test_redq_speed[False-backward] 11.9200ms 11.5062ms 86.9100 Ops/s 85.8624 Ops/s $\color{#35bf28}+1.22\%$
test_redq_speed[True-None] 2.5159ms 2.3311ms 428.9776 Ops/s 421.4256 Ops/s $\color{#35bf28}+1.79\%$
test_redq_speed[True-backward] 4.4312ms 4.0530ms 246.7332 Ops/s 243.8427 Ops/s $\color{#35bf28}+1.19\%$
test_redq_speed[reduce-overhead-None] 2.5391ms 2.3662ms 422.6226 Ops/s 420.0237 Ops/s $\color{#35bf28}+0.62\%$
test_redq_speed[reduce-overhead-backward] 4.3005ms 4.1106ms 243.2710 Ops/s 231.5214 Ops/s $\textbf{\color{#35bf28}+5.07\%}$
test_redq_deprec_speed[False-None] 9.9255ms 9.3730ms 106.6890 Ops/s 108.1089 Ops/s $\color{#d91a1a}-1.31\%$
test_redq_deprec_speed[False-backward] 12.9906ms 12.3615ms 80.8962 Ops/s 81.0568 Ops/s $\color{#d91a1a}-0.20\%$
test_redq_deprec_speed[True-None] 3.0383ms 2.6480ms 377.6500 Ops/s 374.2859 Ops/s $\color{#35bf28}+0.90\%$
test_redq_deprec_speed[True-backward] 4.6634ms 4.4918ms 222.6295 Ops/s 226.3547 Ops/s $\color{#d91a1a}-1.65\%$
test_redq_deprec_speed[reduce-overhead-None] 2.8081ms 2.6399ms 378.8031 Ops/s 375.0395 Ops/s $\color{#35bf28}+1.00\%$
test_redq_deprec_speed[reduce-overhead-backward] 4.8896ms 4.4839ms 223.0222 Ops/s 215.4988 Ops/s $\color{#35bf28}+3.49\%$
test_td3_speed[False-None] 8.2744ms 7.9271ms 126.1489 Ops/s 123.9911 Ops/s $\color{#35bf28}+1.74\%$
test_td3_speed[False-backward] 11.9719ms 10.5314ms 94.9542 Ops/s 94.8107 Ops/s $\color{#35bf28}+0.15\%$
test_td3_speed[True-None] 1.7425ms 1.7046ms 586.6500 Ops/s 606.0504 Ops/s $\color{#d91a1a}-3.20\%$
test_td3_speed[True-backward] 3.4922ms 3.3446ms 298.9933 Ops/s 291.6804 Ops/s $\color{#35bf28}+2.51\%$
test_td3_speed[reduce-overhead-None] 51.2566ms 26.3147ms 38.0015 Ops/s 38.6065 Ops/s $\color{#d91a1a}-1.57\%$
test_td3_speed[reduce-overhead-backward] 1.4451ms 1.3345ms 749.3591 Ops/s 671.6437 Ops/s $\textbf{\color{#35bf28}+11.57\%}$
test_cql_speed[False-None] 17.0134ms 16.6432ms 60.0846 Ops/s 58.9240 Ops/s $\color{#35bf28}+1.97\%$
test_cql_speed[False-backward] 23.1290ms 21.7951ms 45.8818 Ops/s 44.4203 Ops/s $\color{#35bf28}+3.29\%$
test_cql_speed[True-None] 3.7319ms 3.3597ms 297.6414 Ops/s 290.9697 Ops/s $\color{#35bf28}+2.29\%$
test_cql_speed[True-backward] 6.0879ms 5.7537ms 173.8003 Ops/s 172.0723 Ops/s $\color{#35bf28}+1.00\%$
test_cql_speed[reduce-overhead-None] 21.1489ms 13.2154ms 75.6693 Ops/s 74.0801 Ops/s $\color{#35bf28}+2.15\%$
test_cql_speed[reduce-overhead-backward] 1.9443ms 1.8133ms 551.4897 Ops/s 495.9265 Ops/s $\textbf{\color{#35bf28}+11.20\%}$
test_a2c_speed[False-None] 3.2835ms 3.1256ms 319.9369 Ops/s 308.2714 Ops/s $\color{#35bf28}+3.78\%$
test_a2c_speed[False-backward] 6.6213ms 5.9980ms 166.7234 Ops/s 156.0201 Ops/s $\textbf{\color{#35bf28}+6.86\%}$
test_a2c_speed[True-None] 1.5128ms 1.3453ms 743.3537 Ops/s 739.0544 Ops/s $\color{#35bf28}+0.58\%$
test_a2c_speed[True-backward] 3.0963ms 2.9365ms 340.5452 Ops/s 331.1274 Ops/s $\color{#35bf28}+2.84\%$
test_a2c_speed[reduce-overhead-None] 16.1485ms 9.0566ms 110.4165 Ops/s 110.9211 Ops/s $\color{#d91a1a}-0.45\%$
test_a2c_speed[reduce-overhead-backward] 1.5948ms 1.4652ms 682.4880 Ops/s 671.6031 Ops/s $\color{#35bf28}+1.62\%$
test_ppo_speed[False-None] 3.9118ms 3.6377ms 274.8953 Ops/s 260.9618 Ops/s $\textbf{\color{#35bf28}+5.34\%}$
test_ppo_speed[False-backward] 7.1063ms 6.7325ms 148.5340 Ops/s 145.6353 Ops/s $\color{#35bf28}+1.99\%$
test_ppo_speed[True-None] 1.5670ms 1.4129ms 707.7638 Ops/s 691.4050 Ops/s $\color{#35bf28}+2.37\%$
test_ppo_speed[True-backward] 3.2254ms 3.0917ms 323.4493 Ops/s 303.6266 Ops/s $\textbf{\color{#35bf28}+6.53\%}$
test_ppo_speed[reduce-overhead-None] 1.1037ms 0.9695ms 1.0315 KOps/s 1.0412 KOps/s $\color{#d91a1a}-0.93\%$
test_ppo_speed[reduce-overhead-backward] 1.5409ms 1.4145ms 706.9471 Ops/s 617.5146 Ops/s $\textbf{\color{#35bf28}+14.48\%}$
test_reinforce_speed[False-None] 2.3394ms 2.2057ms 453.3673 Ops/s 438.3333 Ops/s $\color{#35bf28}+3.43\%$
test_reinforce_speed[False-backward] 3.3431ms 3.2218ms 310.3847 Ops/s 294.9739 Ops/s $\textbf{\color{#35bf28}+5.22\%}$
test_reinforce_speed[True-None] 1.4474ms 1.2877ms 776.5865 Ops/s 757.2666 Ops/s $\color{#35bf28}+2.55\%$
test_reinforce_speed[True-backward] 3.1093ms 2.9704ms 336.6526 Ops/s 320.3764 Ops/s $\textbf{\color{#35bf28}+5.08\%}$
test_reinforce_speed[reduce-overhead-None] 18.4617ms 10.1489ms 98.5324 Ops/s 99.0052 Ops/s $\color{#d91a1a}-0.48\%$
test_reinforce_speed[reduce-overhead-backward] 1.6656ms 1.5135ms 660.7134 Ops/s 594.2523 Ops/s $\textbf{\color{#35bf28}+11.18\%}$
test_iql_speed[False-None] 9.5715ms 9.1626ms 109.1397 Ops/s 106.2117 Ops/s $\color{#35bf28}+2.76\%$
test_iql_speed[False-backward] 13.3348ms 12.8351ms 77.9114 Ops/s 75.1488 Ops/s $\color{#35bf28}+3.68\%$
test_iql_speed[True-None] 2.5559ms 2.2265ms 449.1392 Ops/s 439.2626 Ops/s $\color{#35bf28}+2.25\%$
test_iql_speed[True-backward] 4.9597ms 4.7700ms 209.6422 Ops/s 202.7684 Ops/s $\color{#35bf28}+3.39\%$
test_iql_speed[reduce-overhead-None] 0.4770s 12.6290ms 79.1827 Ops/s 89.6212 Ops/s $\textbf{\color{#d91a1a}-11.65\%}$
test_iql_speed[reduce-overhead-backward] 2.0666ms 1.9007ms 526.1257 Ops/s 508.0149 Ops/s $\color{#35bf28}+3.57\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.7385ms 6.2720ms 159.4375 Ops/s 156.7672 Ops/s $\color{#35bf28}+1.70\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.5148ms 0.2995ms 3.3387 KOps/s 2.7960 KOps/s $\textbf{\color{#35bf28}+19.41\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5224ms 0.3030ms 3.2999 KOps/s 3.1521 KOps/s $\color{#35bf28}+4.69\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.2871ms 5.9668ms 167.5943 Ops/s 165.6631 Ops/s $\color{#35bf28}+1.17\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.1869ms 0.3373ms 2.9646 KOps/s 2.6725 KOps/s $\textbf{\color{#35bf28}+10.93\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6712ms 0.2442ms 4.0954 KOps/s 4.0510 KOps/s $\color{#35bf28}+1.10\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.5503ms 1.2794ms 781.6465 Ops/s 772.5687 Ops/s $\color{#35bf28}+1.18\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6202ms 1.1911ms 839.5698 Ops/s 829.2713 Ops/s $\color{#35bf28}+1.24\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.3589ms 6.1689ms 162.1027 Ops/s 159.0221 Ops/s $\color{#35bf28}+1.94\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.8607ms 0.4525ms 2.2101 KOps/s 2.0731 KOps/s $\textbf{\color{#35bf28}+6.61\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6181ms 0.3866ms 2.5864 KOps/s 1.9806 KOps/s $\textbf{\color{#35bf28}+30.58\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.2240ms 6.0414ms 165.5242 Ops/s 164.1971 Ops/s $\color{#35bf28}+0.81\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.7643ms 0.2988ms 3.3465 KOps/s 2.8164 KOps/s $\textbf{\color{#35bf28}+18.82\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5343ms 0.2825ms 3.5398 KOps/s 3.1512 KOps/s $\textbf{\color{#35bf28}+12.33\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 8.3648ms 5.9457ms 168.1878 Ops/s 164.9019 Ops/s $\color{#35bf28}+1.99\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8252ms 0.2653ms 3.7692 KOps/s 3.2104 KOps/s $\textbf{\color{#35bf28}+17.40\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5577ms 0.3009ms 3.3229 KOps/s 4.0185 KOps/s $\textbf{\color{#d91a1a}-17.31\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.3337ms 6.1425ms 162.8002 Ops/s 160.2821 Ops/s $\color{#35bf28}+1.57\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.1277ms 0.4173ms 2.3966 KOps/s 2.1762 KOps/s $\textbf{\color{#35bf28}+10.13\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.5917ms 0.3903ms 2.5620 KOps/s 2.1839 KOps/s $\textbf{\color{#35bf28}+17.31\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 7.0556ms 5.4630ms 183.0494 Ops/s 178.1616 Ops/s $\color{#35bf28}+2.74\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 3.7935ms 1.7524ms 570.6329 Ops/s 427.2811 Ops/s $\textbf{\color{#35bf28}+33.55\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 8.3605ms 1.2656ms 790.1662 Ops/s 829.7512 Ops/s $\color{#d91a1a}-4.77\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.4477s 14.4313ms 69.2936 Ops/s 179.7797 Ops/s $\textbf{\color{#d91a1a}-61.46\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 9.3667ms 2.0819ms 480.3302 Ops/s 411.3217 Ops/s $\textbf{\color{#35bf28}+16.78\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 7.0119ms 1.2394ms 806.8186 Ops/s 810.3069 Ops/s $\color{#d91a1a}-0.43\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 7.3476ms 5.7443ms 174.0867 Ops/s 31.3421 Ops/s $\textbf{\color{#35bf28}+455.44\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 9.9731ms 2.2619ms 442.1147 Ops/s 421.0096 Ops/s $\textbf{\color{#35bf28}+5.01\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 6.4547ms 1.3985ms 715.0310 Ops/s 779.3648 Ops/s $\textbf{\color{#d91a1a}-8.25\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 13.8379ms 13.5331ms 73.8931 Ops/s 71.3232 Ops/s $\color{#35bf28}+3.60\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 20.4580ms 17.5727ms 56.9063 Ops/s 58.8901 Ops/s $\color{#d91a1a}-3.37\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 18.7705ms 18.2327ms 54.8464 Ops/s 53.3167 Ops/s $\color{#35bf28}+2.87\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 19.0203ms 17.3294ms 57.7053 Ops/s 56.5051 Ops/s $\color{#35bf28}+2.12\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 18.8218ms 18.2843ms 54.6916 Ops/s 52.9981 Ops/s $\color{#35bf28}+3.20\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 20.4452ms 18.6482ms 53.6244 Ops/s 53.4341 Ops/s $\color{#35bf28}+0.36\%$

@vmoens
Update
f312387 
[ghstack-poisoned]
@vmoens
Update
70da33a 
[ghstack-poisoned]
This was referenced Mar 3, 2025
Merged
Merged
Merged
@vmoens vmoens merged commit 70da33a into gh/vmoens/95/base Mar 3, 2025
69 of 72 checks passed
vmoens added a commit that referenced this pull request Mar 3, 2025
@vmoens
[BugFix] Fix batch_locked check in check_env_specs + error message ca…
9c98b82 
…llable

ghstack-source-id: c722b16
Pull Request resolved: #2817
@vmoens vmoens deleted the gh/vmoens/95/head branch March 3, 2025 15:50
vmoens added a commit that referenced this pull request Mar 8, 2025
@vmoens
[BugFix] Fix batch_locked check in check_env_specs + error message ca…
a2f3a68 
…llable

ghstack-source-id: c722b16
Pull Request resolved: #2817

(cherry picked from commit 9c98b82)
vmoens added a commit that referenced this pull request Mar 10, 2025
@vmoens
[BugFix] Fix batch_locked check in check_env_specs + error message ca…
c797855 
…llable

ghstack-source-id: c722b16
Pull Request resolved: #2817

(cherry picked from commit 9c98b82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot