Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monsterized failures in grouped view #6394

Merged
merged 3 commits into from
Mar 12, 2025
Merged

monsterized failures in grouped view #6394

merged 3 commits into from
Mar 12, 2025

Conversation

wdvr
Copy link
Contributor

@wdvr wdvr commented Mar 12, 2025

show monsterized failures in grouped view in HUD, example:
image

This makes it easy to see if a failure is repeating and when it started, without having to uncollapse or deal with shifting shard columns

  • tooltip shows how many tests per failure type
  • nothing changed in the non-grouped view

Copy link

vercel bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Mar 12, 2025 10:06am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2025
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@malfet malfet merged commit f785154 into main Mar 12, 2025
6 checks passed
@malfet malfet deleted the wdvr/monsterized_grouped branch March 12, 2025 17:01
Camyll pushed a commit that referenced this pull request Mar 13, 2025
show monsterized failures in grouped view in HUD, example:

![image](https://github.com/user-attachments/assets/87576ca8-6ad1-4005-8f2d-8879b8c274c7)

This makes it easy to see if a failure is repeating and when it started,
without having to uncollapse or deal with shifting shard columns

- tooltip shows how many tests per failure type
- nothing changed in the non-grouped view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants