Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styling & CSS Improvements: Add CSS variables for better color consistency #6405

Merged
merged 15 commits into from
Mar 14, 2025

Conversation

wdvr
Copy link
Contributor

@wdvr wdvr commented Mar 13, 2025

Summary

This is the first part of splitting #6392 into three smaller PRs. This PR focuses only on CSS improvements unrelated to dark mode:

  • Add CSS variables for all colors in globals.css
  • Update component CSS files to use these variables
  • Improve styling and tooltip positioning
  • Maintain consistent colors across components
  • Fix layout shifts when hovering over elements

This PR provides better maintainability by centralizing color definitions without adding any dark mode functionality.

Part of #6392

wdvr added 4 commits March 13, 2025 11:29
- Add improved monster styling and layout in JobConclusion.module.css
- Add column width definitions and improve job header styling in hud.module.css
- Add better text truncation and hover behavior for metadata
- Add table wrapper styles and even/odd row styling in minihud.module.css
- Improve tooltip appearance and cursor behavior

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Mar 13, 2025 8:38pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2025
@wdvr wdvr marked this pull request as ready for review March 14, 2025 00:07
Comment on lines +18 to +24
style={{
display: "flex",
alignItems: "center",
gap: "0.25rem",
cursor: "pointer",
whiteSpace: "nowrap",
}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an unnecessary change

Comment on lines +306 to +307
<div style={{ position: "relative", clear: "both" }}>
<div className={styles.controlsContainer}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks unnecessary to be frank, but sure, why not

@malfet malfet merged commit de00dac into main Mar 14, 2025
6 checks passed
@malfet malfet deleted the css-layout-improvements branch March 14, 2025 00:26
@wdvr wdvr changed the title CSS Improvements: Add CSS variables for better color consistency styling & CSS Improvements: Add CSS variables for better color consistency Mar 14, 2025
malfet pushed a commit that referenced this pull request Mar 18, 2025
Regression since #6405 -
making the dropdown of the navbar hide at times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants