[validations] Remove libtorch PRE_CXX11_ABI from matrix. #6433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
seemethere
reviewed
Mar 17, 2025
malfet
requested changes
Mar 17, 2025
There was a problem hiding this comment.
Why those two needs to be done in 1PR? I have no problem with change that removes PRE_CXX11. But I want to see some before/after signal on change that adds numpy. And didn't we want to test that PyTorch is usable without numpy installed? If not, let's just add numpy as PT dependency
atalman
changed the title
malfet
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove libtorch PRE_CXX11_ABI from matrix
failures can be seen here: https://github.com/pytorch/test-infra/actions/runs/13906844473/job/38911966250