Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[viable/strict] Fix failing jobs with unstable issues #6444

Merged
merged 4 commits into from
Mar 19, 2025

Conversation

clee2000
Copy link
Contributor

Follow up to #6362, I forgot that the format is slightly different for test jobs due to the shards

Tested by running on a couple of commits pytorch.
Checked that executorch test config (currently has an issue) got ignored
Checked that commit with trunk job failing was correctly marked as red

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2025 5:03pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2025
@clee2000 clee2000 marked this pull request as ready for review March 19, 2025 16:08
@clee2000 clee2000 requested a review from a team March 19, 2025 16:08
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not, but it feels like we need to have a followup about testing, as something like that was tested last week again

@malfet malfet merged commit 60ef721 into main Mar 19, 2025
6 checks passed
@malfet malfet deleted the csl/fix_viable_strict_update branch March 19, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants