-
Notifications
You must be signed in to change notification settings - Fork 100
Creates placeholder for autorevert lambda #6720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
||
.PHONY: run-local | ||
run-local: venv/bin/python | ||
venv/bin/python auto_revert.py --max-hours 70 --worker-pool-size 8 # --rebuild-table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these arguments intentional? maybe let's replace them with --dry-run
or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, just placeholder. didnt think too much in any of those details.
return parser.parse_args() | ||
|
||
|
||
def main(*args, **kwargs) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need a handler function here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, but I like to be able to run things via CLI, and I am not a big fan of putting things randomly on script root, so it always runs when imported...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! lgtm overall, but please check the comments
…nschmidt/add_python_autorevert_lambda
This PR creates a placeholder for the auto-revert lambda, this lambda is not doing any action for now. The goal is to kickstart an environment where people can contribute to this project in a unified manner.