Skip to content

Creates placeholder for autorevert lambda #6720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2025

Conversation

jeanschmidt
Copy link
Contributor

This PR creates a placeholder for the auto-revert lambda, this lambda is not doing any action for now. The goal is to kickstart an environment where people can contribute to this project in a unified manner.

Copy link

vercel bot commented Jun 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Jun 17, 2025 0:16am

@pytorch-bot pytorch-bot bot added the ci-no-td label Jun 6, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025

.PHONY: run-local
run-local: venv/bin/python
venv/bin/python auto_revert.py --max-hours 70 --worker-pool-size 8 # --rebuild-table
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these arguments intentional? maybe let's replace them with --dry-run or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, just placeholder. didnt think too much in any of those details.

return parser.parse_args()


def main(*args, **kwargs) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a handler function here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, but I like to be able to run things via CLI, and I am not a big fan of putting things randomly on script root, so it always runs when imported...

Copy link
Contributor

@izaitsevfb izaitsevfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm overall, but please check the comments

@jeanschmidt jeanschmidt merged commit 11547bb into main Jun 17, 2025
6 checks passed
@jeanschmidt jeanschmidt deleted the jeanschmidt/add_python_autorevert_lambda branch June 17, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants