Keep going display on HUD: log classifer to handle temp logs #6723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context is pytorch/pytorch#155371
Add a temp_log input to read the log from the temp_log bucket and put the attribute into a temp attribute
This should be a noop in the normal flow
I'm not actually sure if this will work, since the webhook to dynamo code seems to overwrite the entire dynamo entry, so if another webhook gets sent, this attribute would be lost. But webhooks only get sent when something happens, so maybe only when a step finishes or the job finishes? so it might be ok. But also the normal flow doesn't use this so it should be safe in that sense to merge
I'm also not sure if a temp attribute is necessary, since if the above happens the temp attribute will be gone
Possible solutions if the above happens and the temp attribute disappears:
Testing: in fixtures/request.json, changed the raw query string to
job_id=44069312114&repo=pytorch%2Fpytorch&temp_log=true
and did the things in the readme and saw that the temp value got written to dynamo under a new temp attribute, also edited the clickhouse tables to add columns and saw that it got inserted. Also ran it with without temp_log and saw that the normal log got used.