Add python-build-package variant to windows wheel building #7256
+30
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zklaus is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
bot
added
the
CLA Signed
|
Also pinging @alinpahontu2912 as author of the previous PR 👋. |
zklaus
force-pushed
the
mitigate-setup.py-use
branch
5 times, most recently
from
88ec5bb to
1d24fed
Compare
zklaus
force-pushed
the
mitigate-setup.py-use
branch
from
1d24fed to
a015e74
Compare
|
@atalman, done. Do you think it's ok like this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6352, building of wheels for win-arm64 was added. This PR aligns the naming in the workflow more closely with the rest of the workflow file and adds the more modern
python -m buildvariant to the previously used direct invocation ofsetup.py bdist_wheelas is done for other platforms.