Fixed the issue where quorum retry could not catch non-timeout errors.

[zhengchenyu]

#228 implements quorum retry, a very important feature. This ensures that even if Lighthouse temporarily crashes, training will not be terminated.

I tested this by manually shutting down Lighthouse and then restarting it. I found that training could not be resumed. Found the following log:

2025-08-20T17:25:50.494 [INFO] [torchft::manager] - Got quorum response success: Err(Status { code: Unknown, message: "transport error", source: Some(tonic::transport::Error(Transport, hyper::Error(Io, Kind(ConnectionReset)))) })

The reason is that tokio::time::timeout(timeout, client.quorum(request)).await returns Result(Result). When Lighthouse is shut down, it returns Ok(Err), so the Lighthouse client cannot be recreated, resulting in the inability to resume training.

[meta-cla]

Hi @zhengchenyu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!