Base planner class to decouple EmbeddingShardingPlanner from common planner components #3228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77712273 |
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 24, 2025
…lanner components (pytorch#3228) Summary: Context: New planner implementation are extending from OSS planner (EmebddingShardingPlanner) to use common features present in the OSS planner. This is particularly dangers as it limits the development of OSS planner as we as it adds unnecessary dependency on extended planners. This diff: Introducing EmbeddingPlannerBase which adds common components and utils needed to support OSS planner as well as new planner implementations. Reviewed By: mserturk Differential Revision: D77712273
aliafzal
force-pushed
the
export-D77712273
branch
from
ce4b172 to
e59f8da
Compare
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 24, 2025
…lanner components (pytorch#3228) Summary: Context: New planner implementation are extending from OSS planner (EmebddingShardingPlanner) to use common features present in the OSS planner. This is particularly dangers as it limits the development of OSS planner as we as it adds unnecessary dependency on extended planners. This diff: Introducing EmbeddingPlannerBase which adds common components and utils needed to support OSS planner as well as new planner implementations. Reviewed By: mserturk Differential Revision: D77712273
aliafzal
force-pushed
the
export-D77712273
branch
from
e59f8da to
4536b22
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77712273 |
…lanner components (pytorch#3228) Summary: Pull Request resolved: pytorch#3228 Context: New planner implementation are extending from OSS planner (EmebddingShardingPlanner) to use common features present in the OSS planner. This is particularly dangers as it limits the development of OSS planner as we as it adds unnecessary dependency on extended planners. This diff: Introducing EmbeddingPlannerBase which adds common components and utils needed to support OSS planner as well as new planner implementations. Reviewed By: mserturk Differential Revision: D77712273
|
This pull request was exported from Phabricator. Differential Revision: D77712273 |
aliafzal
force-pushed
the
export-D77712273
branch
from
4536b22 to
324de9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
New planner implementation are extending from OSS planner (EmebddingShardingPlanner) to use common features present in the OSS planner. This is particularly dangers as it limits the development of OSS planner as we as it adds unnecessary dependency on extended planners.
This diff:
Introducing EmbeddingPlannerBase which adds common components and utils needed to support OSS planner as well as new planner implementations.
Reviewed By: mserturk
Differential Revision: D77712273