merge depulicate integration tests into one #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
May 29, 2024
ghstack-source-id: a174adc173c8981480d93503bca677cc978108e8 Pull Request resolved: #373
facebook-github-bot
added
the
CLA Signed
As titled. We should use integration test to monitor the health status of torchtitan. [ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
May 29, 2024
ghstack-source-id: 2674375b73e6c79db89716992da2e7c1f7c23a29 Pull Request resolved: #373
wconstab
reviewed
May 29, 2024
README.md
Outdated
| @@ -1,4 +1,4 @@ | |||
| [](https://github.com/pytorch/torchtitan/actions/workflows/unit_test_4gpu.yaml) | |||
| [](https://github.com/pytorch/torchtitan/actions/workflows/integration_test_periodic.yaml) | |||
There was a problem hiding this comment.
it makes sense to me to use the 'periodic' job for the status.
however i didn't realize we had a separate 'integration test' job vs our 'unit test' job.
would like to follow up on why they are separate or if it should just be the same set of tests.
There was a problem hiding this comment.
it looks like integration_test and unit_test_4gpu are identical except for when they run.
- can we rename unit_test to integration test, that's what it really is
- we can merge the yaml i think? (just have 2 entries under the 'on:' field, one for PR and one for cron.
As titled. We should use integration test to monitor the health status of torchtitan. [ghstack-poisoned]
tianyu-l
added a commit
that referenced
this pull request
May 29, 2024
ghstack-source-id: 775591945ff5427cb7e5e9fc7592952b4c746341 Pull Request resolved: #373
tianyu-l
changed the title
tianyu-l
added a commit
that referenced
this pull request
May 30, 2024
ghstack-source-id: 775591945ff5427cb7e5e9fc7592952b4c746341 Pull Request resolved: #373
tianyu-l
added a commit
to tianyu-l/torchtitan_intern24
that referenced
this pull request
Aug 16, 2024
ghstack-source-id: 775591945ff5427cb7e5e9fc7592952b4c746341 Pull Request resolved: pytorch#373
philippguevorguian
pushed a commit
to YerevaNN/YNNtitan
that referenced
this pull request
Aug 17, 2024
ghstack-source-id: 775591945ff5427cb7e5e9fc7592952b4c746341 Pull Request resolved: pytorch#373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As titled. Let's use a single integration test for push, pull request, and periodic monitoring.