Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile with modules and stack #829

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

carmocca
Copy link
Contributor

I find these two arguments very helpful, maybe others do too.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 10, 2025
@fegin
Copy link
Contributor

fegin commented Feb 11, 2025

with_stack has been caused timeout because it significant slow down the profiling for large models. It's better to make it optional.

@carmocca
Copy link
Contributor Author

So do you want that I add a job config argument for with_stack only? Or for both?

@tianyu-l tianyu-l requested a review from fegin February 12, 2025 18:03
@tianyu-l
Copy link
Contributor

I think it's ok to add a job config. I'll let @fegin comment whether we need two, or one for both, or one for with_stack only.

@fegin
Copy link
Contributor

fegin commented Feb 13, 2025

with_stack only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants