Skip to content

Conversation

@fegin
Copy link
Contributor

@fegin fegin commented Feb 12, 2025

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 12, 2025
[ghstack-poisoned]
[ghstack-poisoned]
@fegin fegin requested review from fduwjj and tianyu-l February 12, 2025 08:25
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Copy link
Contributor

@tianyu-l tianyu-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- please address the comment before merging.
oh also CI is failing on memory estimation script.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@fegin fegin merged commit 69b2e62 into gh/fegin/11/base Feb 14, 2025
6 checks passed
fegin added a commit that referenced this pull request Feb 14, 2025
@fegin fegin deleted the gh/fegin/11/head branch February 14, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants