Create //torchx/specs:lib_core #1048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73195094 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
Summary:
IMPORTANT: If you believe you are broken by this diff due to autodeps/codemod having removed a dep to
`//torchx/specs:api` in favor of `//torchx/specs:lib_core` then try adding a manual (`# manual`) dep to `//torchx/specs/fb:api_extended` to fix forward.
**Example:**
```
python_library|binary(
name = "my-lib-or-bin",
srcs = [...],
deps = [
"//torchx/specs:lib_core", # <-- added by autodeps codemod
"//torchx/specs/fb:api_extended", # manual <-- manually add api_extended
...
]
)
```
Milestone 1.1 of torchx-lite (see [doc](https://fburl.com/gdoc/4wxcoaoa) for details)
Creates `//torchx/specs:lib_core` with only the source files of `torchx.specs` module and a minimal set of dependencies for a proper closure of this module.
For BC, we keep `//torchx/specs:lib` and `//torchx/specs:api` as is by adding the existing bundled deps as `manual` so that autodeps doesn't remove them on future codemods.
Switches over to `//torchx/specs:lib_core` for TorchX internal targets (e.g. within `//torchx/...`).
Differential Revision: D73195094
facebook-github-bot
force-pushed
the
export-D73195094
branch
from
81b1add to
055760c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73195094 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
Summary:
IMPORTANT: If you believe you are broken by this diff due to autodeps/codemod having removed a dep to
`//torchx/specs:api` in favor of `//torchx/specs:lib_core` then try adding a manual (`# manual`) dep to `//torchx/specs/fb:api_extended` to fix forward.
**Example:**
```
python_library|binary(
name = "my-lib-or-bin",
srcs = [...],
deps = [
"//torchx/specs:lib_core", # <-- added by autodeps codemod
"//torchx/specs/fb:api_extended", # manual <-- manually add api_extended
...
]
)
```
Milestone 1.1 of torchx-lite (see [doc](https://fburl.com/gdoc/4wxcoaoa) for details)
Creates `//torchx/specs:lib_core` with only the source files of `torchx.specs` module and a minimal set of dependencies for a proper closure of this module.
For BC, we keep `//torchx/specs:lib` and `//torchx/specs:api` as is by adding the existing bundled deps as `manual` so that autodeps doesn't remove them on future codemods.
Switches over to `//torchx/specs:lib_core` for TorchX internal targets (e.g. within `//torchx/...`).
Differential Revision: D73195094
facebook-github-bot
force-pushed
the
export-D73195094
branch
from
055760c to
a826a9f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73195094 |
daniel-ohayon
approved these changes
Apr 23, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
Summary:
IMPORTANT: If you believe you are broken by this diff due to autodeps/codemod having removed a dep to
`//torchx/specs:api` in favor of `//torchx/specs:lib_core` then try adding a manual (`# manual`) dep to `//torchx/specs/fb:api_extended` to fix forward.
**Example:**
```
python_library|binary(
name = "my-lib-or-bin",
srcs = [...],
deps = [
"//torchx/specs:lib_core", # <-- added by autodeps codemod
"//torchx/specs/fb:api_extended", # manual <-- manually add api_extended
...
]
)
```
Milestone 1.1 of torchx-lite (see [doc](https://fburl.com/gdoc/4wxcoaoa) for details)
Creates `//torchx/specs:lib_core` with only the source files of `torchx.specs` module and a minimal set of dependencies for a proper closure of this module.
For BC, we keep `//torchx/specs:lib` and `//torchx/specs:api` as is by adding the existing bundled deps as `manual` so that autodeps doesn't remove them on future codemods.
Switches over to `//torchx/specs:lib_core` for TorchX internal targets (e.g. within `//torchx/...`).
Reviewed By: aay-gup
Differential Revision: D73195094
facebook-github-bot
force-pushed
the
export-D73195094
branch
from
a826a9f to
eddd579
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73195094 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
Summary:
IMPORTANT: If you believe you are broken by this diff due to autodeps/codemod having removed a dep to
`//torchx/specs:api` in favor of `//torchx/specs:lib_core` then try adding a manual (`# manual`) dep to `//torchx/specs/fb:api_extended` to fix forward.
**Example:**
```
python_library|binary(
name = "my-lib-or-bin",
srcs = [...],
deps = [
"//torchx/specs:lib_core", # <-- added by autodeps codemod
"//torchx/specs/fb:api_extended", # manual <-- manually add api_extended
...
]
)
```
Milestone 1.1 of torchx-lite (see [doc](https://fburl.com/gdoc/4wxcoaoa) for details)
Creates `//torchx/specs:lib_core` with only the source files of `torchx.specs` module and a minimal set of dependencies for a proper closure of this module.
For BC, we keep `//torchx/specs:lib` and `//torchx/specs:api` as is by adding the existing bundled deps as `manual` so that autodeps doesn't remove them on future codemods.
Switches over to `//torchx/specs:lib_core` for TorchX internal targets (e.g. within `//torchx/...`).
Reviewed By: aay-gup
Differential Revision: D73195094
facebook-github-bot
force-pushed
the
export-D73195094
branch
from
eddd579 to
69c39cd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73195094 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
Summary:
IMPORTANT: If you believe you are broken by this diff due to autodeps/codemod having removed a dep to
`//torchx/specs:api` in favor of `//torchx/specs:lib_core` then try adding a manual (`# manual`) dep to `//torchx/specs/fb:api_extended` to fix forward.
**Example:**
```
python_library|binary(
name = "my-lib-or-bin",
srcs = [...],
deps = [
"//torchx/specs:lib_core", # <-- added by autodeps codemod
"//torchx/specs/fb:api_extended", # manual <-- manually add api_extended
...
]
)
```
Milestone 1.1 of torchx-lite (see [doc](https://fburl.com/gdoc/4wxcoaoa) for details)
Creates `//torchx/specs:lib_core` with only the source files of `torchx.specs` module and a minimal set of dependencies for a proper closure of this module.
For BC, we keep `//torchx/specs:lib` and `//torchx/specs:api` as is by adding the existing bundled deps as `manual` so that autodeps doesn't remove them on future codemods.
Switches over to `//torchx/specs:lib_core` for TorchX internal targets (e.g. within `//torchx/...`).
Reviewed By: aay-gup
Differential Revision: D73195094
facebook-github-bot
force-pushed
the
export-D73195094
branch
from
69c39cd to
dd70483
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73195094 |
kiukchung
added a commit
that referenced
this pull request
Apr 24, 2025
Summary:
IMPORTANT: If you believe you are broken by this diff due to autodeps/codemod having removed a dep to
`//torchx/specs:api` in favor of `//torchx/specs:lib_core` then try adding a manual (`# manual`) dep to `//torchx/specs/fb:api_extended` to fix forward.
**Example:**
```
python_library|binary(
name = "my-lib-or-bin",
srcs = [...],
deps = [
"//torchx/specs:lib_core", # <-- added by autodeps codemod
"//torchx/specs/fb:api_extended", # manual <-- manually add api_extended
...
]
)
```
Milestone 1.1 of torchx-lite (see [doc](https://fburl.com/gdoc/4wxcoaoa) for details)
Creates `//torchx/specs:lib_core` with only the source files of `torchx.specs` module and a minimal set of dependencies for a proper closure of this module.
For BC, we keep `//torchx/specs:lib` and `//torchx/specs:api` as is by adding the existing bundled deps as `manual` so that autodeps doesn't remove them on future codemods.
Switches over to `//torchx/specs:lib_core` for TorchX internal targets (e.g. within `//torchx/...`).
Reviewed By: aay-gup
Differential Revision: D73195094
kiukchung
force-pushed
the
export-D73195094
branch
from
dd70483 to
1ccf27f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73195094 |
kiukchung
added a commit
that referenced
this pull request
Apr 24, 2025
Summary: Pull Request resolved: #1048 IMPORTANT: If you believe you are broken by this diff due to autodeps/codemod having removed a dep to `//torchx/specs:api` in favor of `//torchx/specs:lib_core` then try adding a manual (`# manual`) dep to `//torchx/specs/fb:api_extended` to fix forward. **Example:** ``` python_library|binary( name = "my-lib-or-bin", srcs = [...], deps = [ "//torchx/specs:lib_core", # <-- added by autodeps codemod "//torchx/specs/fb:api_extended", # manual <-- manually add api_extended ... ] ) ``` Milestone 1.1 of torchx-lite (see [doc](https://fburl.com/gdoc/4wxcoaoa) for details) Creates `//torchx/specs:lib_core` with only the source files of `torchx.specs` module and a minimal set of dependencies for a proper closure of this module. For BC, we keep `//torchx/specs:lib` and `//torchx/specs:api` as is by adding the existing bundled deps as `manual` so that autodeps doesn't remove them on future codemods. Switches over to `//torchx/specs:lib_core` for TorchX internal targets (e.g. within `//torchx/...`). Reviewed By: aay-gup Differential Revision: D73195094
kiukchung
force-pushed
the
export-D73195094
branch
from
1ccf27f to
618af95
Compare
kiukchung
added a commit
that referenced
this pull request
Apr 24, 2025
Summary:
IMPORTANT: If you believe you are broken by this diff due to autodeps/codemod having removed a dep to
`//torchx/specs:api` in favor of `//torchx/specs:lib_core` then try adding a manual (`# manual`) dep to `//torchx/specs/fb:api_extended` to fix forward.
**Example:**
```
python_library|binary(
name = "my-lib-or-bin",
srcs = [...],
deps = [
"//torchx/specs:lib_core", # <-- added by autodeps codemod
"//torchx/specs/fb:api_extended", # manual <-- manually add api_extended
...
]
)
```
Milestone 1.1 of torchx-lite (see [doc](https://fburl.com/gdoc/4wxcoaoa) for details)
Creates `//torchx/specs:lib_core` with only the source files of `torchx.specs` module and a minimal set of dependencies for a proper closure of this module.
For BC, we keep `//torchx/specs:lib` and `//torchx/specs:api` as is by adding the existing bundled deps as `manual` so that autodeps doesn't remove them on future codemods.
Switches over to `//torchx/specs:lib_core` for TorchX internal targets (e.g. within `//torchx/...`).
Reviewed By: aay-gup
Differential Revision: D73195094
kiukchung
force-pushed
the
export-D73195094
branch
from
618af95 to
19da508
Compare
Summary: Pull Request resolved: #1048 IMPORTANT: If you believe you are broken by this diff due to autodeps/codemod having removed a dep to `//torchx/specs:api` in favor of `//torchx/specs:lib_core` then try adding a manual (`# manual`) dep to `//torchx/specs/fb:api_extended` to fix forward. **Example:** ``` python_library|binary( name = "my-lib-or-bin", srcs = [...], deps = [ "//torchx/specs:lib_core", # <-- added by autodeps codemod "//torchx/specs/fb:api_extended", # manual <-- manually add api_extended ... ] ) ``` Milestone 1.1 of torchx-lite (see [doc](https://fburl.com/gdoc/4wxcoaoa) for details) Creates `//torchx/specs:lib_core` with only the source files of `torchx.specs` module and a minimal set of dependencies for a proper closure of this module. For BC, we keep `//torchx/specs:lib` and `//torchx/specs:api` as is by adding the existing bundled deps as `manual` so that autodeps doesn't remove them on future codemods. Switches over to `//torchx/specs:lib_core` for TorchX internal targets (e.g. within `//torchx/...`). Reviewed By: aay-gup Differential Revision: D73195094
|
This pull request was exported from Phabricator. Differential Revision: D73195094 |
kiukchung
force-pushed
the
export-D73195094
branch
from
19da508 to
a75b254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
IMPORTANT: If you believe you are broken by this diff due to autodeps/codemod having removed a dep to
//torchx/specs:apiin favor of//torchx/specs:lib_corethen try adding a manual (# manual) dep to//torchx/specs/fb:api_extendedto fix forward.Example:
Milestone 1.1 of torchx-lite (see doc for details)
Creates
//torchx/specs:lib_corewith only the source files oftorchx.specsmodule and a minimal set of dependencies for a proper closure of this module.For BC, we keep
//torchx/specs:liband//torchx/specs:apias is by adding the existing bundled deps asmanualso that autodeps doesn't remove them on future codemods.Switches over to
//torchx/specs:lib_corefor TorchX internal targets (e.g. within//torchx/...).Differential Revision: D73195094