Skip to content

Conversation

dataproblems
Copy link
Contributor

Changed the condition for including instance type from num_replicas > 1 to num_replicas > 0
- In a situation where an aws batch job had multiple roles associated with the nodes, the batch job definition would error out upon submission due to the missing instance type if any of the roles had a single replica associated with it.

Test plan:

  1. Updated existing unit tests to verify that the instance type gets passed.
  2. Created a job using my patch and validated the behavior.

Copy link

meta-cla bot commented Aug 27, 2025

Hi @dataproblems!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@clumsy
Copy link
Contributor

clumsy commented Aug 27, 2025

For your consideration, @kiukchung @d4l3k

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2025
@facebook-github-bot
Copy link
Contributor

@kiukchung has imported this pull request. If you are a Meta employee, you can view this in D82042908.

@facebook-github-bot
Copy link
Contributor

@kiukchung has imported this pull request. If you are a Meta employee, you can view this in D82042908.

@kiukchung kiukchung merged commit 3bb8b40 into pytorch:main Sep 10, 2025
23 of 24 checks passed
@dataproblems dataproblems deleted the dataproblems_patch branch September 10, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants