fix: Pass instance type into aws batch job definition even when num_replicas = 1 #1102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the condition for including instance type from
num_replicas > 1
tonum_replicas > 0
- In a situation where an aws batch job had multiple roles associated with the nodes, the batch job definition would error out upon submission due to the missing instance type if any of the roles had a single replica associated with it.
Test plan: