Skip to content

Conversation

allenwang28
Copy link
Contributor

Fixes: #1101

Specific changes:

  • Handle job_resources=None for pending jobs (fixing the AttributeError crash)
  • Support both heterogeneous (+) and regular (.) job ID formats in sacct
  • Add SLURM 24.11+ nodes.allocation parsing for running jobs
  • Improve state parsing to handle truncated (CANCELLED+) and verbose states
  • Add unit tests for new compatibility scenarios

On a broader note, while this fixes immediate SLURM 24.11.5 issues, nested compatibility checks without proper SLURM versioning in torchx seems difficult to maintain.

Test plan:

  • Manually on a cluster with 24.11.5
  • Added a few unit tests for the failed test conditions:
pytest torchx/schedulers/test/slurm_scheduler_test.py::SlurmSchedulerTest -vs

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2025
@facebook-github-bot
Copy link
Contributor

@kiukchung has imported this pull request. If you are a Meta employee, you can view this in D81938651.

@kiukchung kiukchung merged commit 1e464ae into pytorch:main Sep 8, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slurm_scheduler.py throws exception with slurm 24.11.5
3 participants