Update RandomErasing value type and doc string #9154
Closed
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9154
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
I think I have fixed all the ufmt and type errors, could you please approve the workflows again? |
|
Hi @rob-luke , sorry I don't think this is something we'll be able to merge. The type annotations of torchvision are unfortunately wrong in plenty of places. Those annotations primarily exist for torchscript tor work, and sadly torchscript and |
|
Thanks for letting me know @NicolasHug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
RandomErasingi was receiving type errors due to the restricted float type forvalue. I have updated the type hinting and docstring to reflect the range of possible types(Union[float, int, str, Sequence[Union[float, int]]]).Thanks for the great package!