Fix marker outline bug & geometry type assignment

qgis · Feb 25, 2025 · 61d047d · 61d047d
1 parent b8ec74d
commit 61d047d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/3d/qgsrubberband3d.cpp b/src/3d/qgsrubberband3d.cpp
@@ -263,6 +263,7 @@ QgsRubberBand3D::MarkerType QgsRubberBand3D::markerType() const
 void QgsRubberBand3D::setMarkerOutlineStyle( const Qt::PenStyle style )
 {
   mMarkerOutlineStyle = style;
+  setMarkerType( markerType() );
 }
 
 Qt::PenStyle QgsRubberBand3D::markerOutlineStyle() const
@@ -334,10 +335,10 @@ void QgsRubberBand3D::addPoint( const QgsPoint &pt )
   updateGeometry();
 }
 
-void QgsRubberBand3D::setGeometry( const QgsGeometry &geometry, const Qgis::GeometryType geometryType )
+void QgsRubberBand3D::setGeometry( const QgsGeometry &geometry )
 {
   mGeometry = geometry;
-  mGeometryType = geometryType;
+  mGeometryType = geometry.type();
 
   updateGeometry();
 }

diff --git a/src/3d/qgsrubberband3d.h b/src/3d/qgsrubberband3d.h
@@ -189,7 +189,7 @@ class _3D_EXPORT QgsRubberBand3D
      *
      * \since QGIS 3.44
      */
-    void setGeometry( const QgsGeometry &geometry, Qgis::GeometryType geometryType );
+    void setGeometry( const QgsGeometry &geometry );
 
     void removeLastPoint();