Change how "Get Z value from project terrain" tool is presented in Mesh Editing #60709
+196
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
1 task
uclaros
reviewed
Feb 26, 2025
|
|
||
| connect( mCheckBoxZ, &QCheckBox::toggled, this, [=]( const bool checked ) { | ||
| if ( checked ) | ||
| mCheckBoxZFromProjectTerrain->setChecked( !checked ); |
There was a problem hiding this comment.
Suggested change
| mCheckBoxZFromProjectTerrain->setChecked( !checked ); | |
| mCheckBoxZFromProjectTerrain->setChecked( false ); |
| } ); | ||
| connect( mCheckBoxZFromProjectTerrain, &QCheckBox::toggled, this, [=]( const bool checked ) { | ||
| if ( checked ) | ||
| mCheckBoxZ->setChecked( !checked ); |
There was a problem hiding this comment.
Suggested change
| mCheckBoxZ->setChecked( !checked ); | |
| mCheckBoxZ->setChecked( false ); |
| * | ||
| * \since QGIS 3.44 | ||
| */ | ||
| void setZFromTerrain( bool enable ); |
There was a problem hiding this comment.
It's probably worth adding a note that when enable is TRUE, the optional project parameter needs to be also used in calculate() method
Comment on lines
+131
to
+134
| if ( mCheckBoxZFromProjectTerrain->isChecked() ) | ||
| { | ||
| mTransformVertices.setZFromTerrain( mCheckBoxZFromProjectTerrain->isChecked() ); | ||
| } |
There was a problem hiding this comment.
Either
Suggested change
| if ( mCheckBoxZFromProjectTerrain->isChecked() ) | |
| { | |
| mTransformVertices.setZFromTerrain( mCheckBoxZFromProjectTerrain->isChecked() ); | |
| } | |
| if ( mCheckBoxZFromProjectTerrain->isChecked() ) | |
| { | |
| mTransformVertices.setZFromTerrain( true ); | |
| } |
or
Suggested change
| if ( mCheckBoxZFromProjectTerrain->isChecked() ) | |
| { | |
| mTransformVertices.setZFromTerrain( mCheckBoxZFromProjectTerrain->isChecked() ); | |
| } | |
| mTransformVertices.setZFromTerrain( mCheckBoxZFromProjectTerrain->isChecked() ); |
?
Comment on lines
+673
to
+676
| if ( mZFromTerrain ) | ||
| { | ||
| if ( project ) | ||
| { |
There was a problem hiding this comment.
Suggested change
| if ( mZFromTerrain ) | |
| { | |
| if ( project ) | |
| { | |
| if ( mZFromTerrain && project ) | |
| { |
uclaros
reviewed
Feb 26, 2025
| <item row="4" column="0"> | ||
| <widget class="QCheckBox" name="mCheckBoxZFromProjectTerrain"> | ||
| <property name="text"> | ||
| <string>Get Z value from project terrain</string> |
There was a problem hiding this comment.
Wouldn't it be more proper to say:
Suggested change
| <string>Get Z value from project terrain</string> | |
| <string>Get Z value from the project terrain</string> |
Any native speaker?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the way how Get Z value from project terrain is presented to the user according to #60512 (comment).
The Z Value and Get Z value from project terrain checkboxes are mutually exclusive, so user can either select one or the other.
Works with both Preview Transform and Apply Transform.