-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add merge policies #60710
base: master
Are you sure you want to change the base?
Add merge policies #60710
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
src/core/qgis.h
Outdated
LargestGeometry, //!< Use value from the feature with the largest geometry \since QGIS 3.44 | ||
MinimumValue, //!< Use the minimum value from the features-to-be-merged \since QGIS 3.44 | ||
MaximumValue, //!< Use the maximum value from the features-to-be-merged \since QGIS 3.44 | ||
SkipAttribute, //!< Use a null value \since QGIS 3.44 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use an explicit name for this one:
SkipAttribute, //!< Use a null value \since QGIS 3.44 | |
SetToNull, //!< Use a null value \since QGIS 3.44 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson Changed. Should the change be reflected in the GUI as well (combobox etc.)? I initially went with SkipAttribute
since that terminology is already used in the merge dialog itself.
And thank you for the review!
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
Fixes #59494.
Similarly to already existing Split and Duplicate "policies" this PR implements Merge Policies, which determine the initial values in the Merge Features dialog. The PR includes the following merge policies:
From the existing
Qgis::FieldDomainMergePolicy
enum:New policies:
Initial merge dialog before PR:

Initial merge dialog after PR:

Configuring the policies:

Funded by the National Land Survey of Finland.