Project Translation considers descriptions of Value Map Widget #60744
+1,435
−343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
…rectly in a map instead of maps in a list.
3nids
approved these changes
Feb 26, 2025
| if ( categories.testFlag( Forms ) ) | ||
| { | ||
| const QString widgetType = fieldWidgetElement.attribute( QStringLiteral( "type" ) ); | ||
| const QDomElement cfgElem = fieldConfigElement.elementsByTagName( QStringLiteral( "config" ) ).at( 0 ).toElement(); | ||
| const QDomElement optionsElem = cfgElem.childNodes().at( 0 ).toElement(); | ||
| QVariantMap optionsMap = QgsXmlUtils::readVariant( optionsElem ).toMap(); | ||
| if ( widgetType == QLatin1String( "ValueRelation" ) ) | ||
| // translate widged configuration strings |
There was a problem hiding this comment.
Suggested change
| // translate widged configuration strings | |
| // translate widget configuration strings |
| for ( int i = 0, row = 0; i < valueList.count(); i++, row++ ) | ||
| { | ||
| QMap<QString, QVariant> translatedValueMap; | ||
| QString translatedKey = context.projectTranslator()->translate( QStringLiteral( "project:layers:%1:fields:%2:valuemapdescriptions" ).arg( layerNode.namedItem( QStringLiteral( "id" ) ).toElement().text(), fieldName ), valueList[i].toMap().constBegin().key() ); |
There was a problem hiding this comment.
so there's a map in the list? and only one entry in this map with key/value?
3nids
added
backport queued_ltr_backports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value Map descriptions can now be translated as well.
The values are of course the same.
This fixes #56089
Additionally I included missing tests for the Value Relation value translation.
The ts file is committed as well, so the tests can be extended in future with low effort.
This handles only value maps stored as QLists (means after this implementation #6091 and > 3.4)