Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-3_40] Always fallback to default coordinate operations when bounding box transfrom fails #60766

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

qgis-bot
Copy link
Collaborator

Backport #60759
Authored by: @nyalldawson

…ansfrom fails

Bounding box transforms are inherently approximate, so we can safely
just fallback to the proj default operation if the user-specified
operation fails when transforming a bounding box.

This fixes cases where the user-specified operation involves a
grid shift and the bounds to transform falls outside of the grid.
In this case proj_trans_bounds fails. By falling back to a proj
default operation and re-trying then we get a valid approximate
transformation of the bounding box.

Fixes map rendering issues when users are using a grid shift operation
to transform layers to map CRS

Fixes #60737
Fixes #60753
@github-actions github-actions bot added this to the 3.40.5 milestone Feb 26, 2025
Copy link

github-actions bot commented Feb 26, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 6f07a90)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 6f07a90)

@alexbruy alexbruy merged commit ba30fff into release-3_40 Feb 26, 2025
35 checks passed
@alexbruy alexbruy deleted the backport-60759-to-release-3_40 branch February 26, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants