add(configuration): ability to store configuration in [tool:qgis-plugin-ci] section in plugin's metadata.txt#416
Conversation
e08709f to
4d20dcb
Compare
3nids
left a comment
There was a problem hiding this comment.
Tihs makes sense to me.
Some thoughts though:
- adding a 4th config option for me should wait for v3. There we decide for a single source of truth to reduce code quantity and chances of different behaviors? -- maybe 2, but not 4 ;)
- I guess this will mean adding a new param to the CLI to give it the location of the metadata file (this will be one parameter less for the plugin path). Other options are non valid for me (moving/copying or configuring) since that would mean a required building step to test the plugin while you develop.
I'm just seeing the need for a cleanup before putting more, but I'm ok to make it land in v2 if you want to, no strong opinion.
I don't think so. I guess the checks are mainly checking on missing mandatory fields rather than extra ones and wouldn't probably take them into consideration (not saved in the DB, will stay in the metadata) if not declared in the validators. |
…in-c] section in plugin's metadata.txt
4d20dcb to
179e77a
Compare
@3nids I agree that this results in a lot of different configuration files. Come to think of it, this is due to the fact that, on the one hand, a tool often tends to provide its own configuration file, and on the other hand, the Python ecosystem is still torn between It is hard to choose, but if we had to keep only 3, I would suggest:
And if we had to keep only 2:
Maybe we can add this new option in V2 and remove another one in V3? Thoughts @Gustry?
Sure.
Not sure to understand here. |
Description
We already reading/writing the plugin's metadata.txt so why not loading full config from there? Well, talking with colleagues, from a plugin dev perspective, it looks like a good idea to store everything in the same config file.
@Xpirix @timlinux is there a risk to see this extra section spotted by checks running at publish time?
plugin_pathis still mandatory but maybe we could add a small lookup logic tyo find it (as parent folder of the metadata.txt) in a next PR?I used claude.ai to write unit tests.
Funded by Oslandia.
Author's checklist
Fixes #11111at the bottom of the commit message.Tip
If you forgot to do this, don't be shy and write the same statement into this text field with the pull request description.
AI tool usage
Reviewer's checklist