Skip to content

Raise error when saving metadata without a service #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Raise error when saving metadata without a service #1278

wants to merge 4 commits into from

Conversation

@coruscating
Copy link
Collaborator

@coruscating coruscating commented Sep 27, 2023 •
edited
Loading

Summary

Closes #1134. Note that save() already raised an error when there's no service and suppress_errors is False, so this PR specifically handles the case when save_metadata() is invoked separately.

This also adds error handling for saving figures.

@coruscating coruscating requested a review from gadial September 27, 2023 17:58
@coruscating coruscating mentioned this pull request Sep 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gadial gadial Awaiting requested review from gadial

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

If experiment_data.save() fails it should raise an exception

1 participant

@coruscating