Always log prepare script stdout and stderr (#1480)

- Always log prepare_script stdout to info level, and stderr to warn level
qltysh · Feb 7, 2025 · eb0d0ef · eb0d0ef
1 parent 23f3b6e
commit eb0d0ef
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 6 deletions.
diff --git a/qlty-check/src/executor/driver.rs b/qlty-check/src/executor/driver.rs
@@ -505,7 +505,8 @@ impl Driver {
             .dir(dir)
             .full_env(plan.tool.env())
             .stderr_capture()
-            .stdout_capture();
+            .stdout_capture()
+            .unchecked();
 
         debug!("Running prepare_script: {}", &rerun);
         let timer = Instant::now();
@@ -517,18 +518,35 @@ impl Driver {
                 invocation_label, &rerun
             )
         })?;
-        let duration = timer.elapsed().as_secs_f64();
 
         info!(
-            "{}: prepare_script ran {} in {:.3}s (exit {}): {}",
+            "{}: prepare_script ran {} in {:.3}s (exit {}): stdout: {}",
             plan.invocation_id,
             invocation_label,
-            duration,
+            timer.elapsed().as_secs_f64(),
             output.status.code().unwrap_or(-1),
             String::from_utf8(output.stdout).unwrap_or_default()
         );
 
-        Ok(())
+        if !output.stderr.is_empty() {
+            warn!(
+                "{}: {}: stderr: {}",
+                plan.invocation_id,
+                invocation_label,
+                String::from_utf8(output.stderr).unwrap_or_default()
+            );
+        }
+
+        if output.status.success() {
+            Ok(())
+        } else {
+            bail!(
+                "{}: prepare_script exited with non-zero code {}: {}",
+                plan.invocation_id,
+                output.status.code().unwrap_or(-1),
+                rerun
+            );
+        }
     }
 }
 

diff --git a/qlty-cli/tests/cmd/check/prepare_script_fail.stderr b/qlty-cli/tests/cmd/check/prepare_script_fail.stderr
@@ -1,2 +1,2 @@
-❌ Failed to run prepare_script for prepare_script_fail/lint:[..]INVALID_COMMAND[..]
+❌ [..]: prepare_script exited with non-zero code [..]:[..]INVALID_COMMAND[..]
 ...