Binary to generate qlty.toml validation schema using Taplo #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sounds counter-intuitive, but extensions and tools like [Taplo](https://taplo.tamasfe.dev/) ([Even Better TOML](https://marketplace.visualstudio.com/items?itemName=tamasfe.even-better-toml)) support validating TOML files with JSON schemas. This PR aims to provide the infrastructure to generate a JSON schema for use in these tools. A schema file can be generated with ```sh cargo run --bin qlty-config-generate-schema > schema.json ``` This PR does not generate the schema or use it anywhere yet.
|
The code coverage on the diff in this pull request is 0.0% Drilldown
(*) Indirect Changes: These files had changes to their code coverage, but were not modified in this pull request. Learn More |
|
This is awesome! This will be a huge help for users to get their TOML changes correct. |
brynary
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sounds counter-intuitive, but extensions and tools like Taplo (Even Better TOML) support validating TOML files with JSON schemas. This PR aims to provide the infrastructure to generate a JSON schema for use in these tools.
A schema file can be generated with
cargo run --bin qlty-config-generate-schema > schema.jsonThis PR does not generate the schema or use it anywhere yet.