Fix Jacoco parser to not throw error when no lines for source file #1473

marschattha · 2025-02-04T19:53:51Z

Some times the output from Jacoco parser can have missing line data, right now we error when that happens. This PR handles that scenario.

qltysh · 2025-02-04T19:55:29Z

Tool	Category	Rule	Count
qlty	Structure	Deeply nested control flow (level = 5)	1

qlty successfully analyzed this pull request in 1m.

qltysh · 2025-02-04T19:55:33Z

qlty-coverage/src/parser/jacoco.rs

+                        for _x in (line_hits.len() as i64)..(line.nr - 1) {
+                            line_hits.push(-1)


Deeply nested control flow (level = 5) [qlty:nested-control-flow]

qltysh · 2025-02-04T19:55:51Z

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will not change total coverage.

File Coverage Changes

Path	File Coverage Δ	Indirect
qlty-coverage/src/parser/jacoco.rs	0.1

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Fix Jacoco parser to not throw error when no lines for source file

4733a2a

marschattha requested a review from brynary February 4, 2025 19:54

qltysh bot reviewed Feb 4, 2025

View reviewed changes

brynary approved these changes Feb 4, 2025

View reviewed changes

marschattha merged commit 68097c9 into main Feb 4, 2025
8 checks passed

marschattha deleted the ma/fix_jacoco_parser_to_allow_no_lines branch February 4, 2025 20:06

Provide feedback

		for _x in (line_hits.len() as i64)..(line.nr - 1) {
		line_hits.push(-1)