Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for simplecov-json in simplecov parser #1475

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

marschattha
Copy link
Member

Some customers are reported to be using simeplcov-json gem to generate coverage report, which generates it differently from the current and legacy simplecov format that we current support, this PR adds support for simplecov-json format.
https://github.com/vicentllongo/simplecov-json

@marschattha marschattha requested a review from brynary February 4, 2025 22:22
Copy link
Contributor

qltysh bot commented Feb 4, 2025

Diff Coverage: The code coverage on the diff in this pull request is 97.6%.

Total Coverage: This PR will increase coverage by 0.04%.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-check/src/executor/driver.rs -0.9
qlty-check/src/tool/command_builder.rs 2.6
qlty-check/src/tool/download.rs 0.7
qlty-check/src/tool/ruby/sys/linux.rs -1.6
qlty-check/src/tool/ruby/sys/macos.rs 3.1
qlty-cli/src/initializer/scanner/gemfile.rs 0.3
qlty-cloud/src/auth/auth_flow.rs -0.5
qlty-config/src/library.rs 0.5
qlty-coverage/src/parser/simplecov.rs 0.1
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Member

@brynary brynary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I reading this correctly that the single Simplecov parser will now auto-detect "regular"/legacy simplecov vs simplecov-json?

@marschattha
Copy link
Member Author

Yes, should we add it as a separate parser?
Might make things difficult on auto detect.

Previously we were only detecting simplecov and legacy simplecov format and if we got neither it would return empty.
This PR adds a third state(simplecov-json) if first two fail before returning empty if none.

@marschattha marschattha merged commit bcef508 into main Feb 5, 2025
8 checks passed
@marschattha marschattha deleted the ma/add_support_for_simplecov_json branch February 5, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants