Fix path target mode when used in subdirectory #1476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you apply a formatting change bubbled up from
qlty check
command while in a sub directory, the application fails with anResult::unwrap() on an Err value
.The root of that issue lies in the fact that when you apply the format this way, formatter is run with only selected file paths (which are project root relative and not relative to cwd) and TargetMode is set to Path when that happens. Instead of normalizing relative paths based on cwd I think just using absoluete paths is a better approach and less likely to cause any issues.