Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default behavior for missing output #1478

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Conversation

marschattha
Copy link
Member

#1466 again with output_missing = "parse" for all linters except eslint and kubelint

Copy link
Contributor

qltysh bot commented Feb 5, 2025

Diff Coverage: The code coverage on the diff in this pull request is 73.5%.

Total Coverage: This PR will not change total coverage.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-check/src/executor/invocation_result.rs 0.6
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Member

@brynary brynary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. So these snapshot changes look OK?

@marschattha
Copy link
Member Author

Added snapshot tests for trufflehog and markdownlint for scenarios where there is no output/issues to report.
Not sure if any other plugins behave similarly but these two do so added their tests.

@marschattha marschattha merged commit 23f3b6e into main Feb 5, 2025
11 checks passed
@marschattha marschattha deleted the bh-output-missing branch February 5, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants